From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 2/6] usb: phy: tegra: Fix wrong PHY parameters Date: Thu, 01 Aug 2013 15:09:08 -0600 Message-ID: <51FACE74.3070909@wwwdotorg.org> References: <1375292522-7855-1-git-send-email-ttynkkynen@nvidia.com> <1375292522-7855-3-git-send-email-ttynkkynen@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1375292522-7855-3-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Tuomas Tynkkynen Cc: balbi-l0cyMroinI0@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 07/31/2013 11:41 AM, Tuomas Tynkkynen wrote: > Some of the PHY parameters are not set according to the TRMs: > > - UTMIP_FS_PREABMLE_J should be set, not cleared > - UTMIP_XCVR_LSBIAS_SEL should be cleared, not set > - UTMIP_PD_CHRG should be set in host mode and cleared in device mode > - UTMIP_XCVR_SETUP is a two-part field; the upper bits were not set > diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c > #define UTMIP_XCVR_SETUP(x) (((x) & 0xf) << 0) > +#define UTMIP_XCVR_SETUP_MSB(x) ((((x) & 0x7f) >> 4) << 22) You may as well s/0x7f/0x70/ since the shift clears the 4 LSBs. I'm pretty sure I mentioned this in downstream review. Perhaps check my review comments to see if anything else was missed? -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757156Ab3HAVJN (ORCPT ); Thu, 1 Aug 2013 17:09:13 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:33677 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753905Ab3HAVJL (ORCPT ); Thu, 1 Aug 2013 17:09:11 -0400 Message-ID: <51FACE74.3070909@wwwdotorg.org> Date: Thu, 01 Aug 2013 15:09:08 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Tuomas Tynkkynen CC: balbi@ti.com, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, gregkh@linuxfoundation.org, stern@rowland.harvard.edu Subject: Re: [PATCH 2/6] usb: phy: tegra: Fix wrong PHY parameters References: <1375292522-7855-1-git-send-email-ttynkkynen@nvidia.com> <1375292522-7855-3-git-send-email-ttynkkynen@nvidia.com> In-Reply-To: <1375292522-7855-3-git-send-email-ttynkkynen@nvidia.com> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/31/2013 11:41 AM, Tuomas Tynkkynen wrote: > Some of the PHY parameters are not set according to the TRMs: > > - UTMIP_FS_PREABMLE_J should be set, not cleared > - UTMIP_XCVR_LSBIAS_SEL should be cleared, not set > - UTMIP_PD_CHRG should be set in host mode and cleared in device mode > - UTMIP_XCVR_SETUP is a two-part field; the upper bits were not set > diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c > #define UTMIP_XCVR_SETUP(x) (((x) & 0xf) << 0) > +#define UTMIP_XCVR_SETUP_MSB(x) ((((x) & 0x7f) >> 4) << 22) You may as well s/0x7f/0x70/ since the shift clears the 4 LSBs. I'm pretty sure I mentioned this in downstream review. Perhaps check my review comments to see if anything else was missed?