From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx111.postini.com [74.125.245.111]) by kanga.kvack.org (Postfix) with SMTP id B14BF6B0031 for ; Thu, 1 Aug 2013 18:13:25 -0400 (EDT) Message-ID: <51FADD6F.3040804@linux.intel.com> Date: Thu, 01 Aug 2013 15:13:03 -0700 From: Dave Hansen MIME-Version: 1.0 Subject: Re: [PATCH] drivers: base: new memory config sysfs driver for large memory systems References: <1374786680-26197-1-git-send-email-sjenning@linux.vnet.ibm.com> <20130725234007.GB18349@kroah.com> <20130726144251.GB4379@variantweb.net> <20130801205724.GA13585@kroah.com> In-Reply-To: <20130801205724.GA13585@kroah.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Greg Kroah-Hartman Cc: Seth Jennings , Nathan Fontenot , Andrew Morton , "Rafael J. Wysocki" , Nivedita Singhvi , Michael J Wolf , linux-kernel@vger.kernel.org, Linux-MM On 08/01/2013 01:57 PM, Greg Kroah-Hartman wrote: >> > "memory" is the name used by the current sysfs memory layout code in >> > drivers/base/memory.c. So it can't be the same unless we are going to >> > create a toggle a boot time to select between the models, which is >> > something I am looking to add if this code/design is acceptable to >> > people. > I know it can't be the same, but this is like "memory_v2" or something, > right? I suggest you make it an either/or option, given that you feel > the existing layout just will not work properly for you. If there are existing tools or applications that look for memory hotplug events, how does this interact with those? I know you guys have control over the ppc software that actually performs the probe/online operations, but what about other apps? I also don't seem to see the original post to LKML. Did you send privately to Greg, then he cc'd LKML on his reply? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx172.postini.com [74.125.245.172]) by kanga.kvack.org (Postfix) with SMTP id 400056B0032 for ; Fri, 2 Aug 2013 11:50:42 -0400 (EDT) Received: from /spool/local by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 3 Aug 2013 01:40:43 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 307772BB004F for ; Sat, 3 Aug 2013 01:50:34 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r72FYk2e55574724 for ; Sat, 3 Aug 2013 01:34:50 +1000 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r72FoTrW014323 for ; Sat, 3 Aug 2013 01:50:29 +1000 Date: Fri, 2 Aug 2013 10:50:26 -0500 From: Seth Jennings Subject: Re: [PATCH] drivers: base: new memory config sysfs driver for large memory systems Message-ID: <20130802155026.GA4550@variantweb.net> References: <1374786680-26197-1-git-send-email-sjenning@linux.vnet.ibm.com> <20130725234007.GB18349@kroah.com> <20130726144251.GB4379@variantweb.net> <20130801205724.GA13585@kroah.com> <51FADD6F.3040804@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51FADD6F.3040804@linux.intel.com> Sender: owner-linux-mm@kvack.org List-ID: To: Dave Hansen Cc: Greg Kroah-Hartman , Nathan Fontenot , Andrew Morton , "Rafael J. Wysocki" , Nivedita Singhvi , Michael J Wolf , linux-kernel@vger.kernel.org, Linux-MM On Thu, Aug 01, 2013 at 03:13:03PM -0700, Dave Hansen wrote: > On 08/01/2013 01:57 PM, Greg Kroah-Hartman wrote: > >> > "memory" is the name used by the current sysfs memory layout code in > >> > drivers/base/memory.c. So it can't be the same unless we are going to > >> > create a toggle a boot time to select between the models, which is > >> > something I am looking to add if this code/design is acceptable to > >> > people. > > I know it can't be the same, but this is like "memory_v2" or something, > > right? I suggest you make it an either/or option, given that you feel > > the existing layout just will not work properly for you. > > If there are existing tools or applications that look for memory hotplug > events, how does this interact with those? I know you guys have control > over the ppc software that actually performs the probe/online > operations, but what about other apps? After taking a closer look, I've decided to rework this to preserve more of the existing layout. Should be posting it next Monday. > > I also don't seem to see the original post to LKML. Did you send > privately to Greg, then he cc'd LKML on his reply? Yeah :-/ My mail relay settings were messed up and my system tried to deliver the mail directly to recipients; some of which worked and some failed (spam/firewall filters, etc). Sigh... Seth -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755287Ab3GYXiE (ORCPT ); Thu, 25 Jul 2013 19:38:04 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40559 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752418Ab3GYXiC (ORCPT ); Thu, 25 Jul 2013 19:38:02 -0400 Date: Thu, 25 Jul 2013 16:38:00 -0700 From: Greg Kroah-Hartman To: Seth Jennings Cc: Nathan Fontenot , Andrew Morton , "Rafael J. Wysocki" , Nivedita Singhvi , Michael J Wolf , linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: base: new memory config sysfs driver for large memory systems Message-ID: <20130725233800.GA18349@kroah.com> References: <1374786680-26197-1-git-send-email-sjenning@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1374786680-26197-1-git-send-email-sjenning@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 25, 2013 at 04:11:20PM -0500, Seth Jennings wrote: > From: Nathan Fontenot > > Large memory systems (1TB or more) experience boot delays on the order > of minutes due to the initializing the memory configuration part of > sysfs at /sys/devices/system/memory/. > > ppc64 has a memory block size of 256M and (I think) x86 is 128M. With 1TB > of RAM and a 256M block size, that's 4k memory blocks with 20 sysfs > entries per block that's around 80k items that need be created at boot > time in sysfs. Some systems go up to 16TB where the issue is > even more severe. > > This patch is a prototype for a new sysfs memory layout where the > entries are created on demand by writing memory block numbers into a > "show" and "hide" files to create and destroy the memory block > configuration attributes in sysfs. This would decouple the number of > sysfs entries created at boot time from the memory size, resulting in a > sysfs initialization time that doesn't increase and memory size > increase. > > Signed-off-by: Seth Jennings > Signed-off-by: Nathan Fontenot How does this tie into the patches Nathan sent yesterday for memory hotplug stuff that I thought modified the same part of the kernel? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755585Ab3GYXkL (ORCPT ); Thu, 25 Jul 2013 19:40:11 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40564 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753048Ab3GYXkI (ORCPT ); Thu, 25 Jul 2013 19:40:08 -0400 Date: Thu, 25 Jul 2013 16:40:07 -0700 From: Greg Kroah-Hartman To: Seth Jennings Cc: Nathan Fontenot , Andrew Morton , "Rafael J. Wysocki" , Nivedita Singhvi , Michael J Wolf , linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: base: new memory config sysfs driver for large memory systems Message-ID: <20130725234007.GB18349@kroah.com> References: <1374786680-26197-1-git-send-email-sjenning@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1374786680-26197-1-git-send-email-sjenning@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 25, 2013 at 04:11:20PM -0500, Seth Jennings wrote: > +#define MEMFS_CLASS_NAME "memoryfs" One question, a "*fs" name in the kernel usually implies it is a separate filesystem, which this isn't at all, it's just a "normal" class/subsystem in the kernel. So how about "memory" instead? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756743Ab3G3PXt (ORCPT ); Tue, 30 Jul 2013 11:23:49 -0400 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:57909 "EHLO e23smtp02.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754856Ab3G3PXp (ORCPT ); Tue, 30 Jul 2013 11:23:45 -0400 Date: Fri, 26 Jul 2013 09:42:51 -0500 From: Seth Jennings To: Greg Kroah-Hartman Cc: Nathan Fontenot , Andrew Morton , "Rafael J. Wysocki" , Nivedita Singhvi , Michael J Wolf , linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: base: new memory config sysfs driver for large memory systems Message-ID: <20130726144251.GB4379@variantweb.net> References: <1374786680-26197-1-git-send-email-sjenning@linux.vnet.ibm.com> <20130725234007.GB18349@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130725234007.GB18349@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13073015-5490-0000-0000-000003E8C445 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 25, 2013 at 04:40:07PM -0700, Greg Kroah-Hartman wrote: > On Thu, Jul 25, 2013 at 04:11:20PM -0500, Seth Jennings wrote: > > +#define MEMFS_CLASS_NAME "memoryfs" > > One question, a "*fs" name in the kernel usually implies it is a > separate filesystem, which this isn't at all, it's just a "normal" > class/subsystem in the kernel. So how about "memory" instead? "memory" is the name used by the current sysfs memory layout code in drivers/base/memory.c. So it can't be the same unless we are going to create a toggle a boot time to select between the models, which is something I am looking to add if this code/design is acceptable to people. The design is that people with large memory systems would pass a boot parameter that selects this alternate layout, so that the majority of non-large-memory users and any userspace programs that depend on the old layout would be unaffected. In the meantime, the name "memfs" was chosen for the RFC so that people could compile and run the new model concurrently with the current model. Seth From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756792Ab3G3PYs (ORCPT ); Tue, 30 Jul 2013 11:24:48 -0400 Received: from e28smtp06.in.ibm.com ([122.248.162.6]:47237 "EHLO e28smtp06.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756632Ab3G3PXq (ORCPT ); Tue, 30 Jul 2013 11:23:46 -0400 Date: Fri, 26 Jul 2013 09:33:44 -0500 From: Seth Jennings To: Greg Kroah-Hartman Cc: Nathan Fontenot , Andrew Morton , "Rafael J. Wysocki" , Nivedita Singhvi , Michael J Wolf , linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: base: new memory config sysfs driver for large memory systems Message-ID: <20130726143344.GA4379@variantweb.net> References: <1374786680-26197-1-git-send-email-sjenning@linux.vnet.ibm.com> <20130725233800.GA18349@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130725233800.GA18349@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13073015-9574-0000-0000-000008F3DECB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 25, 2013 at 04:38:00PM -0700, Greg Kroah-Hartman wrote: > On Thu, Jul 25, 2013 at 04:11:20PM -0500, Seth Jennings wrote: > > From: Nathan Fontenot > > > > Large memory systems (1TB or more) experience boot delays on the order > > of minutes due to the initializing the memory configuration part of > > sysfs at /sys/devices/system/memory/. > > > > ppc64 has a memory block size of 256M and (I think) x86 is 128M. With 1TB > > of RAM and a 256M block size, that's 4k memory blocks with 20 sysfs > > entries per block that's around 80k items that need be created at boot > > time in sysfs. Some systems go up to 16TB where the issue is > > even more severe. > > > > This patch is a prototype for a new sysfs memory layout where the > > entries are created on demand by writing memory block numbers into a > > "show" and "hide" files to create and destroy the memory block > > configuration attributes in sysfs. This would decouple the number of > > sysfs entries created at boot time from the memory size, resulting in a > > sysfs initialization time that doesn't increase and memory size > > increase. > > > > Signed-off-by: Seth Jennings > > Signed-off-by: Nathan Fontenot > > How does this tie into the patches Nathan sent yesterday for memory > hotplug stuff that I thought modified the same part of the kernel? So this patch introduces the new layout in a new file drives/base/memfs.c (which, in light of your last comment should probably be something more like largememory.c). It doesn't clash with Nathan's, but it doesn't contain the new is_memblock_[removable|offline] functions or the new "release" attribute. But that can be added easily. Seth From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757397Ab3HAU4K (ORCPT ); Thu, 1 Aug 2013 16:56:10 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53775 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752214Ab3HAU4J (ORCPT ); Thu, 1 Aug 2013 16:56:09 -0400 Date: Fri, 2 Aug 2013 04:57:24 +0800 From: Greg Kroah-Hartman To: Seth Jennings Cc: Nathan Fontenot , Andrew Morton , "Rafael J. Wysocki" , Nivedita Singhvi , Michael J Wolf , linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: base: new memory config sysfs driver for large memory systems Message-ID: <20130801205724.GA13585@kroah.com> References: <1374786680-26197-1-git-send-email-sjenning@linux.vnet.ibm.com> <20130725234007.GB18349@kroah.com> <20130726144251.GB4379@variantweb.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130726144251.GB4379@variantweb.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 26, 2013 at 09:42:51AM -0500, Seth Jennings wrote: Sorry for the delay, google decided to mark your responses as "spam" :( > On Thu, Jul 25, 2013 at 04:40:07PM -0700, Greg Kroah-Hartman wrote: > > On Thu, Jul 25, 2013 at 04:11:20PM -0500, Seth Jennings wrote: > > > +#define MEMFS_CLASS_NAME "memoryfs" > > > > One question, a "*fs" name in the kernel usually implies it is a > > separate filesystem, which this isn't at all, it's just a "normal" > > class/subsystem in the kernel. So how about "memory" instead? > > "memory" is the name used by the current sysfs memory layout code in > drivers/base/memory.c. So it can't be the same unless we are going to > create a toggle a boot time to select between the models, which is > something I am looking to add if this code/design is acceptable to > people. I know it can't be the same, but this is like "memory_v2" or something, right? I suggest you make it an either/or option, given that you feel the existing layout just will not work properly for you. > The design is that people with large memory systems would pass a boot > parameter that selects this alternate layout, so that the majority > of non-large-memory users and any userspace programs that depend on the > old layout would be unaffected. > > In the meantime, the name "memfs" was chosen for the RFC so that people > could compile and run the new model concurrently with the current model. It's a really bad name for a driver subsystem, please don't use it. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757439Ab3HAU4o (ORCPT ); Thu, 1 Aug 2013 16:56:44 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53779 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751723Ab3HAU4n (ORCPT ); Thu, 1 Aug 2013 16:56:43 -0400 Date: Fri, 2 Aug 2013 04:57:58 +0800 From: Greg Kroah-Hartman To: Seth Jennings Cc: Nathan Fontenot , Andrew Morton , "Rafael J. Wysocki" , Nivedita Singhvi , Michael J Wolf , linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: base: new memory config sysfs driver for large memory systems Message-ID: <20130801205758.GB13585@kroah.com> References: <1374786680-26197-1-git-send-email-sjenning@linux.vnet.ibm.com> <20130725233800.GA18349@kroah.com> <20130726143344.GA4379@variantweb.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130726143344.GA4379@variantweb.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 26, 2013 at 09:33:44AM -0500, Seth Jennings wrote: > On Thu, Jul 25, 2013 at 04:38:00PM -0700, Greg Kroah-Hartman wrote: > > On Thu, Jul 25, 2013 at 04:11:20PM -0500, Seth Jennings wrote: > > > From: Nathan Fontenot > > > > > > Large memory systems (1TB or more) experience boot delays on the order > > > of minutes due to the initializing the memory configuration part of > > > sysfs at /sys/devices/system/memory/. > > > > > > ppc64 has a memory block size of 256M and (I think) x86 is 128M. With 1TB > > > of RAM and a 256M block size, that's 4k memory blocks with 20 sysfs > > > entries per block that's around 80k items that need be created at boot > > > time in sysfs. Some systems go up to 16TB where the issue is > > > even more severe. > > > > > > This patch is a prototype for a new sysfs memory layout where the > > > entries are created on demand by writing memory block numbers into a > > > "show" and "hide" files to create and destroy the memory block > > > configuration attributes in sysfs. This would decouple the number of > > > sysfs entries created at boot time from the memory size, resulting in a > > > sysfs initialization time that doesn't increase and memory size > > > increase. > > > > > > Signed-off-by: Seth Jennings > > > Signed-off-by: Nathan Fontenot > > > > How does this tie into the patches Nathan sent yesterday for memory > > hotplug stuff that I thought modified the same part of the kernel? > > So this patch introduces the new layout in a new file > drives/base/memfs.c (which, in light of your last comment should > probably be something more like largememory.c). > > It doesn't clash with Nathan's, but it doesn't contain the new > is_memblock_[removable|offline] functions or the new "release" > attribute. But that can be added easily. Can you two please work together on this so I we don't have to deal with competing patch sets and get confused as to what is really going on here? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757868Ab3HAWN0 (ORCPT ); Thu, 1 Aug 2013 18:13:26 -0400 Received: from mga09.intel.com ([134.134.136.24]:3657 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755177Ab3HAWNZ (ORCPT ); Thu, 1 Aug 2013 18:13:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.89,797,1367996400"; d="scan'208";a="380344143" Message-ID: <51FADD6F.3040804@linux.intel.com> Date: Thu, 01 Aug 2013 15:13:03 -0700 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: Greg Kroah-Hartman CC: Seth Jennings , Nathan Fontenot , Andrew Morton , "Rafael J. Wysocki" , Nivedita Singhvi , Michael J Wolf , linux-kernel@vger.kernel.org, Linux-MM Subject: Re: [PATCH] drivers: base: new memory config sysfs driver for large memory systems References: <1374786680-26197-1-git-send-email-sjenning@linux.vnet.ibm.com> <20130725234007.GB18349@kroah.com> <20130726144251.GB4379@variantweb.net> <20130801205724.GA13585@kroah.com> In-Reply-To: <20130801205724.GA13585@kroah.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/01/2013 01:57 PM, Greg Kroah-Hartman wrote: >> > "memory" is the name used by the current sysfs memory layout code in >> > drivers/base/memory.c. So it can't be the same unless we are going to >> > create a toggle a boot time to select between the models, which is >> > something I am looking to add if this code/design is acceptable to >> > people. > I know it can't be the same, but this is like "memory_v2" or something, > right? I suggest you make it an either/or option, given that you feel > the existing layout just will not work properly for you. If there are existing tools or applications that look for memory hotplug events, how does this interact with those? I know you guys have control over the ppc software that actually performs the probe/online operations, but what about other apps? I also don't seem to see the original post to LKML. Did you send privately to Greg, then he cc'd LKML on his reply? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754231Ab3HBPuo (ORCPT ); Fri, 2 Aug 2013 11:50:44 -0400 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:59764 "EHLO e23smtp01.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754003Ab3HBPum (ORCPT ); Fri, 2 Aug 2013 11:50:42 -0400 Date: Fri, 2 Aug 2013 10:50:26 -0500 From: Seth Jennings To: Dave Hansen Cc: Greg Kroah-Hartman , Nathan Fontenot , Andrew Morton , "Rafael J. Wysocki" , Nivedita Singhvi , Michael J Wolf , linux-kernel@vger.kernel.org, Linux-MM Subject: Re: [PATCH] drivers: base: new memory config sysfs driver for large memory systems Message-ID: <20130802155026.GA4550@variantweb.net> References: <1374786680-26197-1-git-send-email-sjenning@linux.vnet.ibm.com> <20130725234007.GB18349@kroah.com> <20130726144251.GB4379@variantweb.net> <20130801205724.GA13585@kroah.com> <51FADD6F.3040804@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51FADD6F.3040804@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13080215-1618-0000-0000-00000463E5EE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 01, 2013 at 03:13:03PM -0700, Dave Hansen wrote: > On 08/01/2013 01:57 PM, Greg Kroah-Hartman wrote: > >> > "memory" is the name used by the current sysfs memory layout code in > >> > drivers/base/memory.c. So it can't be the same unless we are going to > >> > create a toggle a boot time to select between the models, which is > >> > something I am looking to add if this code/design is acceptable to > >> > people. > > I know it can't be the same, but this is like "memory_v2" or something, > > right? I suggest you make it an either/or option, given that you feel > > the existing layout just will not work properly for you. > > If there are existing tools or applications that look for memory hotplug > events, how does this interact with those? I know you guys have control > over the ppc software that actually performs the probe/online > operations, but what about other apps? After taking a closer look, I've decided to rework this to preserve more of the existing layout. Should be posting it next Monday. > > I also don't seem to see the original post to LKML. Did you send > privately to Greg, then he cc'd LKML on his reply? Yeah :-/ My mail relay settings were messed up and my system tried to deliver the mail directly to recipients; some of which worked and some failed (spam/firewall filters, etc). Sigh... Seth