From: Aaron Lu <aaron.lwe@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
"Rafael J. Wysocki" <rjw@sisk.pl>, Len Brown <lenb@kernel.org>,
Zhang Rui <rui.zhang@intel.com>, Jiri Kosina <trivial@kernel.org>
Subject: Re: [PATCH 3/3] acpi: video: remove unnecessary casting
Date: Fri, 02 Aug 2013 09:58:32 +0800 [thread overview]
Message-ID: <51FB1248.8040107@gmail.com> (raw)
In-Reply-To: <1375400641-1694-4-git-send-email-felipe.contreras@gmail.com>
On 08/02/2013 07:44 AM, Felipe Contreras wrote:
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Looks good to me, except that no change log feels a little weird.
Reviewed-by: Aaron Lu <aaron.lu@intel.com>
Thanks,
Aaron
> ---
> drivers/acpi/video.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> index b07573f..11bafbe 100644
> --- a/drivers/acpi/video.c
> +++ b/drivers/acpi/video.c
> @@ -236,8 +236,7 @@ static int acpi_video_get_brightness(struct backlight_device *bd)
> {
> unsigned long long cur_level;
> int i;
> - struct acpi_video_device *vd =
> - (struct acpi_video_device *)bl_get_data(bd);
> + struct acpi_video_device *vd = bl_get_data(bd);
>
> if (acpi_video_device_lcd_get_level_current(vd, &cur_level, false))
> return -EINVAL;
> @@ -255,8 +254,7 @@ static int acpi_video_get_brightness(struct backlight_device *bd)
> static int acpi_video_set_brightness(struct backlight_device *bd)
> {
> int request_level = bd->props.brightness + 2;
> - struct acpi_video_device *vd =
> - (struct acpi_video_device *)bl_get_data(bd);
> + struct acpi_video_device *vd = bl_get_data(bd);
>
> return acpi_video_device_lcd_set_level(vd,
> vd->brightness->levels[request_level]);
>
prev parent reply other threads:[~2013-08-02 1:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 23:43 [PATCH 0/3] acpi: video: trivial cleanups Felipe Contreras
2013-08-01 23:43 ` [PATCH 1/3] acpi: video: trivial costmetic cleanups Felipe Contreras
2013-08-02 1:50 ` Aaron Lu
2013-08-02 4:15 ` Felipe Contreras
2013-08-02 14:05 ` Rafael J. Wysocki
2013-08-02 17:52 ` Felipe Contreras
2013-08-03 0:07 ` Rafael J. Wysocki
2013-08-03 1:34 ` Felipe Contreras
2013-08-03 11:38 ` Rafael J. Wysocki
2013-08-03 20:28 ` Felipe Contreras
2013-08-01 23:44 ` [PATCH 2/3] acpi: video: trivial style cleanups Felipe Contreras
2013-08-02 1:55 ` Aaron Lu
2013-08-02 4:18 ` Felipe Contreras
2013-08-02 14:09 ` Rafael J. Wysocki
2013-08-02 17:56 ` Felipe Contreras
2013-08-02 17:56 ` Felipe Contreras
2013-08-03 0:01 ` Rafael J. Wysocki
2013-08-03 0:01 ` Rafael J. Wysocki
2013-08-03 1:28 ` Felipe Contreras
2013-08-03 1:28 ` Felipe Contreras
2013-08-01 23:44 ` [PATCH 3/3] acpi: video: remove unnecessary casting Felipe Contreras
2013-08-02 1:58 ` Aaron Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FB1248.8040107@gmail.com \
--to=aaron.lwe@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=rui.zhang@intel.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.