From: Zach Levis <zml@linux.vnet.ibm.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@ZenIV.linux.org.uk>,
Evgeniy Polyakov <zbr@ioremap.net>,
Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] exec: minor cleanups + minor fix
Date: Fri, 02 Aug 2013 07:38:27 -0700 [thread overview]
Message-ID: <51FBC463.7040409@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130802140916.GA25401@redhat.com>
On 08/02/2013 07:09 AM, Oleg Nesterov wrote:
> On 08/01, Oleg Nesterov wrote:
>>
>> Andrew,
>>
>> By discussion with Zach, please drop
>>
>> fs-binfmts-add-a-name-field-to-the-binfmt-struct.patch
>> fs-binfmts-better-handling-of-binfmt-loops.patch
>> fs-binfmts-whitespace-fixes-with-scripts-cleanfile.patch
>>
>> Zach is working on v2.
>>
>> Meanwhile, can't we cleanup search_binary_handler() a bit? It
>> doesn't look nice imho. And we can certainly cleanup it more
>> (perhaps I'll try tomorrow). The error handling, request_module()
>> logic and even "for (try=0; try<2; try++)" looks horrible imho.
>
> Seriously, I think this should be cleanuped too.
>
> Zach, I am sorry if you already rebased your changes, I'll send
> a couple more patches today.
>
Don't worry -- I've been holding off on sending v2 for your changes
today. It's not much git wrangling to apply your additional patches anyway.
> Oleg.
>
next prev parent reply other threads:[~2013-08-02 14:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 19:04 [PATCH 0/3] exec: minor cleanups + minor fix Oleg Nesterov
2013-08-01 19:05 ` [PATCH 1/3] exec: introduce exec_binprm() for "depth == 0" code Oleg Nesterov
2013-08-03 19:05 ` Kees Cook
2013-08-04 14:35 ` Oleg Nesterov
2013-08-04 17:13 ` Kees Cook
2013-08-01 19:05 ` [PATCH 2/3] exec: kill "int depth" in search_binary_handler() Oleg Nesterov
2013-08-03 18:28 ` Kees Cook
2013-08-03 18:55 ` [PATCH v2 " Oleg Nesterov
2013-08-03 19:31 ` Kees Cook
2013-08-01 19:05 ` [PATCH 3/3] exec: proc_exec_connector() should be called only once Oleg Nesterov
2013-08-03 19:10 ` Kees Cook
2013-08-02 14:09 ` [PATCH 0/3] exec: minor cleanups + minor fix Oleg Nesterov
2013-08-02 14:38 ` Zach Levis [this message]
2013-08-04 16:30 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FBC463.7040409@linux.vnet.ibm.com \
--to=zml@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=viro@ZenIV.linux.org.uk \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.