From: George Cherian <george.cherian@ti.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-usb@vger.kernel.org, balbi@ti.com,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] usb: musb: dsps: use proper child nodes
Date: Fri, 2 Aug 2013 20:19:27 +0530 [thread overview]
Message-ID: <51FBC6F7.7050509@ti.com> (raw)
In-Reply-To: <51FB8A14.8040008@linutronix.de>
On 8/2/2013 3:59 PM, Sebastian Andrzej Siewior wrote:
> On 08/01/2013 01:30 PM, Sebastian Andrzej Siewior wrote:
>> On 08/01/2013 12:52 PM, Sebastian Andrzej Siewior wrote:
>>> On 08/01/2013 07:24 AM, George Cherian wrote:
>>>>> b/arch/arm/boot/dts/am33xx.dtsi
>>>>> index 38b446b..0f756ca 100644
>>>>> --- a/arch/arm/boot/dts/am33xx.dtsi
>>>>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>>>>> @@ -333,21 +337,85 @@
>>>>> status = "disabled";
>>>>> };
>>>>> - usb@47400000 {
>>>>> - compatible = "ti,musb-am33xx";
>>>>> - reg = <0x47400000 0x1000 /* usbss */
>>>>> - 0x47401000 0x800 /* musb instance 0 */
>>>>> - 0x47401800 0x800>; /* musb instance 1 */
>>>>> - interrupts = <17 /* usbss */
>>>>> - 18 /* musb instance 0 */
>>>>> - 19>; /* musb instance 1 */
>>>>> - multipoint = <1>;
>>>>> - num-eps = <16>;
>>>>> - ram-bits = <12>;
>>>>> - port0-mode = <3>;
>>>>> - port1-mode = <3>;
>>>>> - power = <250>;
>>>>> + usb: usb@47400000 {
>>>>> + compatible = "ti,am33xx-usb";
>>>>> + reg = <0x47400000 0x1000>;
>>>>> + ranges;
>>>>> + #address-cells = <1>;
>>>>> + #size-cells = <1>;
>>>>> ti,hwmods = "usb_otg_hs";
>>>>> + status = "disabled";
>>>>> +
>>>>> + ctrl_mod: control@44e10000 {
>>>>> + compatible = "ti,am335x-ctrl-module";
>>>>> + reg = <0x44e10000 0x650>;
>>>> Do you really need to map Control Module base to 0x650? If some other
>>>> driver does this mapping
>>> This is what I cam currently not sure about. Either we minimize the
>>> register window and introduce two (the other wakeup) or we keep using
>>> the same reset driver for other devices.
>> I mean drivers/reset or something like that.
> If there are no further comments / preferences on this I'm going to
> shrink to registers and make usb only.
Yes, USB only makes sense for now.
>
> Sebastian
>
--
-George
WARNING: multiple messages have this Message-ID (diff)
From: George Cherian <george.cherian@ti.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: <linux-usb@vger.kernel.org>, <balbi@ti.com>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] usb: musb: dsps: use proper child nodes
Date: Fri, 2 Aug 2013 20:19:27 +0530 [thread overview]
Message-ID: <51FBC6F7.7050509@ti.com> (raw)
In-Reply-To: <51FB8A14.8040008@linutronix.de>
On 8/2/2013 3:59 PM, Sebastian Andrzej Siewior wrote:
> On 08/01/2013 01:30 PM, Sebastian Andrzej Siewior wrote:
>> On 08/01/2013 12:52 PM, Sebastian Andrzej Siewior wrote:
>>> On 08/01/2013 07:24 AM, George Cherian wrote:
>>>>> b/arch/arm/boot/dts/am33xx.dtsi
>>>>> index 38b446b..0f756ca 100644
>>>>> --- a/arch/arm/boot/dts/am33xx.dtsi
>>>>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>>>>> @@ -333,21 +337,85 @@
>>>>> status = "disabled";
>>>>> };
>>>>> - usb@47400000 {
>>>>> - compatible = "ti,musb-am33xx";
>>>>> - reg = <0x47400000 0x1000 /* usbss */
>>>>> - 0x47401000 0x800 /* musb instance 0 */
>>>>> - 0x47401800 0x800>; /* musb instance 1 */
>>>>> - interrupts = <17 /* usbss */
>>>>> - 18 /* musb instance 0 */
>>>>> - 19>; /* musb instance 1 */
>>>>> - multipoint = <1>;
>>>>> - num-eps = <16>;
>>>>> - ram-bits = <12>;
>>>>> - port0-mode = <3>;
>>>>> - port1-mode = <3>;
>>>>> - power = <250>;
>>>>> + usb: usb@47400000 {
>>>>> + compatible = "ti,am33xx-usb";
>>>>> + reg = <0x47400000 0x1000>;
>>>>> + ranges;
>>>>> + #address-cells = <1>;
>>>>> + #size-cells = <1>;
>>>>> ti,hwmods = "usb_otg_hs";
>>>>> + status = "disabled";
>>>>> +
>>>>> + ctrl_mod: control@44e10000 {
>>>>> + compatible = "ti,am335x-ctrl-module";
>>>>> + reg = <0x44e10000 0x650>;
>>>> Do you really need to map Control Module base to 0x650? If some other
>>>> driver does this mapping
>>> This is what I cam currently not sure about. Either we minimize the
>>> register window and introduce two (the other wakeup) or we keep using
>>> the same reset driver for other devices.
>> I mean drivers/reset or something like that.
> If there are no further comments / preferences on this I'm going to
> shrink to registers and make usb only.
Yes, USB only makes sense for now.
>
> Sebastian
>
--
-George
next prev parent reply other threads:[~2013-08-02 14:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 20:16 am335x, multi instance and phy support, v3 Sebastian Andrzej Siewior
2013-07-30 20:16 ` [PATCH 1/5] usb: phy: rename nop_usb_xceiv => usb_phy_gen_xceiv Sebastian Andrzej Siewior
2013-07-30 20:16 ` [PATCH 2/5] usb: phy: phy-generic: export init functions Sebastian Andrzej Siewior
2013-07-30 20:16 ` [PATCH 3/5] usb: phy: Add AM335x PHY driver Sebastian Andrzej Siewior
2013-08-01 5:36 ` George Cherian
2013-08-01 10:55 ` Sebastian Andrzej Siewior
2013-07-30 20:16 ` [PATCH 4/5] usb: musb: dsps: remove the hardcoded phy pieces Sebastian Andrzej Siewior
2013-07-30 20:16 ` [PATCH 5/5] usb: musb: dsps: use proper child nodes Sebastian Andrzej Siewior
2013-08-01 5:24 ` George Cherian
2013-08-01 10:52 ` Sebastian Andrzej Siewior
2013-08-01 11:30 ` Sebastian Andrzej Siewior
[not found] ` <51FA46C3.9000101-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2013-08-02 10:29 ` Sebastian Andrzej Siewior
2013-08-02 10:29 ` Sebastian Andrzej Siewior
2013-08-02 14:49 ` George Cherian [this message]
2013-08-02 14:49 ` George Cherian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FBC6F7.7050509@ti.com \
--to=george.cherian@ti.com \
--cc=balbi@ti.com \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.