From: Stephen Warren <swarren@wwwdotorg.org>
To: Mark Brown <broonie@kernel.org>
Cc: Olof Johansson <olof@lixom.net>, Bard Liao <bardliao@realtek.com>,
alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: dapm: Fix empty list check in dapm_new_mux()
Date: Fri, 02 Aug 2013 09:43:50 -0600 [thread overview]
Message-ID: <51FBD3B6.4050403@wwwdotorg.org> (raw)
In-Reply-To: <20130801184427.GX9858@sirena.org.uk>
On 08/01/2013 12:44 PM, Mark Brown wrote:
> On Thu, Aug 01, 2013 at 06:30:38PM +0200, Lars-Peter Clausen
> wrote:
>> list_first_entry() will always return a valid pointer, even if
>> the list is empty. So the check whether path is NULL will always
>> be false. So we end up calling
>> dapm_create_or_share_mixmux_kcontrol() with a path struct that
>> points right in the middle of the widget struct and by trying to
>> modify the path the widgets memory will become corrupted. Fix
>> this by using list_emtpy() to check if the widget doesn't have
>> any paths.
>
> Applied, thanks - looking at this I'm surprised we've not been
> running into problems before.
I don't see this in the ASoC git tree, in either for-next, fix/dapm,
or topic/dapm.
next prev parent reply other threads:[~2013-08-02 15:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 16:30 [PATCH] ASoC: dapm: Fix empty list check in dapm_new_mux() Lars-Peter Clausen
2013-08-01 17:20 ` Stephen Warren
2013-08-01 18:44 ` Mark Brown
2013-08-02 15:43 ` Stephen Warren [this message]
2013-08-02 16:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FBD3B6.4050403@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.