From: Nikolay Aleksandrov <nikolay@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, andy@greyhouse.net, fubar@us.ibm.com
Subject: Re: [PATCH net] bonding: fix arp monitoring with vlan slaves
Date: Sat, 03 Aug 2013 00:40:48 +0200 [thread overview]
Message-ID: <51FC3570.4020102@redhat.com> (raw)
In-Reply-To: <20130802.153212.1340051334413929810.davem@davemloft.net>
On 08/03/2013 12:32 AM, David Miller wrote:
> From: Nikolay Aleksandrov <nikolay@redhat.com>
> Date: Fri, 2 Aug 2013 18:41:05 +0200
>
>> From: Nikolay Aleksandrov <Nikolay Aleksandrov nikolay@redhat.com>
>>
>> When arp monitoring is enabled the bonding relies on slaves'
>> dev_trans_start() value to check if the slave link is up or not, but for
>> 8021q devices that value is either stale or 0, and can't be used. So use
>> the 8021q's underlying device value.
>>
>> Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
>
> Handling this specially in bonding isn't really ideal.
>
Indeed, it's not really a bonding problem.
> Please either hide this detail in dev_trans_start(), or (preferrably)
> have vlan_dev_hard_start_xmit() set the trans_start timestamp
> properly thus making this just work for everything.
>
> Thanks.
>
Yep, I prefer option 2 as well. I will submit a patch tomorrow, thank you
for the suggestions.
Nik
next prev parent reply other threads:[~2013-08-02 22:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 16:41 [PATCH net] bonding: fix arp monitoring with vlan slaves Nikolay Aleksandrov
2013-08-02 22:32 ` David Miller
2013-08-02 22:40 ` Nikolay Aleksandrov [this message]
2013-08-02 23:17 ` Eric Dumazet
2013-08-02 23:29 ` Nikolay Aleksandrov
2013-08-02 23:59 ` Jay Vosburgh
2013-08-03 0:03 ` Eric Dumazet
2013-08-03 0:21 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FC3570.4020102@redhat.com \
--to=nikolay@redhat.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.