From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:38237 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752450Ab3HCQth (ORCPT ); Sat, 3 Aug 2013 12:49:37 -0400 Message-ID: <51FD42B6.5090909@kernel.org> Date: Sat, 03 Aug 2013 18:49:42 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Sachin Kamat CC: linux-iio@vger.kernel.org, jic23@cam.ac.uk, Lars-Peter Clausen Subject: Re: [PATCH 2/6] iio: imu: adis16480: Use devm_iio_device_alloc References: <1375173868-13235-1-git-send-email-sachin.kamat@linaro.org> <1375173868-13235-2-git-send-email-sachin.kamat@linaro.org> In-Reply-To: <1375173868-13235-2-git-send-email-sachin.kamat@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 07/30/13 09:44, Sachin Kamat wrote: > Using devm_iio_device_alloc makes code simpler. > > Signed-off-by: Sachin Kamat > Cc: Lars-Peter Clausen Applied to the togreg branch of iio.git. Thanks, Jonathan > --- > drivers/iio/imu/adis16480.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c > index b7db383..dd4206c 100644 > --- a/drivers/iio/imu/adis16480.c > +++ b/drivers/iio/imu/adis16480.c > @@ -839,7 +839,7 @@ static int adis16480_probe(struct spi_device *spi) > struct adis16480 *st; > int ret; > > - indio_dev = iio_device_alloc(sizeof(*st)); > + indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st)); > if (indio_dev == NULL) > return -ENOMEM; > > @@ -857,11 +857,11 @@ static int adis16480_probe(struct spi_device *spi) > > ret = adis_init(&st->adis, indio_dev, spi, &adis16480_data); > if (ret) > - goto error_free_dev; > + return ret; > > ret = adis_setup_buffer_and_trigger(&st->adis, indio_dev, NULL); > if (ret) > - goto error_free_dev; > + return ret; > > ret = adis16480_initial_setup(indio_dev); > if (ret) > @@ -879,8 +879,6 @@ error_stop_device: > adis16480_stop_device(indio_dev); > error_cleanup_buffer: > adis_cleanup_buffer_and_trigger(&st->adis, indio_dev); > -error_free_dev: > - iio_device_free(indio_dev); > return ret; > } > > @@ -894,8 +892,6 @@ static int adis16480_remove(struct spi_device *spi) > > adis_cleanup_buffer_and_trigger(&st->adis, indio_dev); > > - iio_device_free(indio_dev); > - > return 0; > } > >