Re: [PATCH 4/9] staging:iio:hmc5843: 'add' is a poor abbreviation for address

[Jonathan Cameron <jic23@kernel.org>]

On 07/27/13 16:31, Peter Meerwald wrote:
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Cc: Shubhrajyoti Datta <shubhrajyoti@ti.com>
Confusing indeed.

Applied to the togreg branch of iio.git.

Thanks,
> ---
>  drivers/staging/iio/magnetometer/hmc5843.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/magnetometer/hmc5843.c b/drivers/staging/iio/magnetometer/hmc5843.c
> index 79117ad..465dc2a 100644
> --- a/drivers/staging/iio/magnetometer/hmc5843.c
> +++ b/drivers/staging/iio/magnetometer/hmc5843.c
> @@ -556,14 +556,14 @@ static int hmc5843_read_raw(struct iio_dev *indio_dev,
>  	return -EINVAL;
>  }
>  
> -#define HMC5843_CHANNEL(axis, add)					\
> +#define HMC5843_CHANNEL(axis, addr)					\
>  	{								\
>  		.type = IIO_MAGN,					\
>  		.modified = 1,						\
>  		.channel2 = IIO_MOD_##axis,				\
>  		.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),		\
>  		.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE),	\
> -		.address = add						\
> +		.address = addr						\
>  	}
>  
>  static const struct iio_chan_spec hmc5843_channels[] = {
>