From: Jens Lehmann <Jens.Lehmann@web.de>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
git@vger.kernel.org, judge.packham@gmail.com, iveqy@iveqy.com,
Jorge-Juan.Garcia-Garcia@ensimag.imag.fr, gitster@pobox.com,
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Subject: Re: [PATCH 1/2] submodule: fix confusing variable name
Date: Sun, 04 Aug 2013 19:34:48 +0200 [thread overview]
Message-ID: <51FE90B8.8030203@web.de> (raw)
In-Reply-To: <20130803181415.GF2893@elie.Belkin>
Am 03.08.2013 20:14, schrieb Jonathan Nieder:
> brian m. carlson wrote:
>
>> cmd_summary reads the output of git diff, but reads in the submodule
>> path into a variable called name. Since this variable does not
>> contain the name of the submodule, but the path, rename it to be
>> clearer what data it actually holds.
>
> Nice.
I totally agree. Paths and names of submodules are often confused
(especially as they are identical for a submodule that was never
moved), so cleaning up our sources so they use the correct term is
The Right Thing.
But we'll have to use sm_path here (like everywhere else in the
submodule script), because we'll run into problems under Windows
otherwise (see 64394e3ae9 for details). Apart from that the patch
is fine.
next prev parent reply other threads:[~2013-08-04 17:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-03 17:14 Don't print status output with submodule.<name>.ignore=all brian m. carlson
2013-08-03 17:14 ` [PATCH 1/2] submodule: fix confusing variable name brian m. carlson
2013-08-03 18:14 ` Jonathan Nieder
2013-08-04 17:34 ` Jens Lehmann [this message]
2013-08-04 21:29 ` Fredrik Gustafsson
2013-08-06 17:33 ` Jens Lehmann
2013-08-08 17:44 ` Ramsay Jones
2013-08-09 17:26 ` Fredrik Gustafsson
2013-08-09 18:53 ` Junio C Hamano
2013-08-11 19:53 ` Mark Levedahl
2013-08-03 17:14 ` [PATCH 2/2] submodule: don't print status output with ignore=all brian m. carlson
2013-08-03 18:24 ` Jonathan Nieder
2013-08-04 18:24 ` Jens Lehmann
2013-08-10 16:37 ` brian m. carlson
2013-08-11 16:03 ` brian m. carlson
2013-08-11 18:33 ` Jonathan Nieder
2013-08-17 16:27 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FE90B8.8030203@web.de \
--to=jens.lehmann@web.de \
--cc=Jorge-Juan.Garcia-Garcia@ensimag.imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=iveqy@iveqy.com \
--cc=jrnieder@gmail.com \
--cc=judge.packham@gmail.com \
--cc=ramsay@ramsay1.demon.co.uk \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.