From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v2] kvm-unit-tests: VMX: Split VMX test suites to separate file Date: Sun, 04 Aug 2013 20:46:00 +0200 Message-ID: <51FEA168.7030401@web.de> References: <1375639493-8321-1-git-send-email-yzt356@gmail.com> <51FE989D.9020308@web.de> <4AC0C8B6-B1C5-416F-9A49-A52B0581C845@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VgnVr7abVbaOuT8lwQGaxM5DO8CHkiaI6" Cc: "kvm@vger.kernel.org" , "gleb@redhat.com" , "pbonzini@redhat.com" To: Gmail Return-path: Received: from mout.web.de ([212.227.17.11]:59718 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752774Ab3HDSqF (ORCPT ); Sun, 4 Aug 2013 14:46:05 -0400 Received: from mchn199C.mchp.siemens.de ([95.157.58.223]) by smtp.web.de (mrweb002) with ESMTPSA (Nemesis) id 0MA5ZB-1UvIjQ41gP-00BHT3 for ; Sun, 04 Aug 2013 20:46:03 +0200 In-Reply-To: <4AC0C8B6-B1C5-416F-9A49-A52B0581C845@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VgnVr7abVbaOuT8lwQGaxM5DO8CHkiaI6 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: quoted-printable On 2013-08-04 20:25, Gmail wrote: > =D4=DA 2013-8-5=A3=AC2:08=A3=ACJan Kiszka =D0=B4=B5= =C0=A3=BA >=20 >> On 2013-08-04 20:04, Arthur Chunqi Li wrote: >>> @@ -432,6 +432,22 @@ enum Ctrl1 { >>> #define HYPERCALL_MASK 0xFFF >>> #define HYPERCALL_VMEXIT 0x1 >>> >>> + >>> +extern u64 hypercall_field; >>> +extern u32 vpid_cnt; >>> +extern ulong fix_cr0_set, fix_cr0_clr; >>> +extern ulong fix_cr4_set, fix_cr4_clr; >>> +extern struct regs regs; >>> +extern struct vmx_test *current; >>> +extern bool launched; >> >> You didn't address my question if we need them all to write test cases= >> or if some are actually core internal. > You are right. Not all global variants in last version is necessary for= test cases, so I move some of them to vmx.c internal. The rest ones in t= his version are needed by tests to identify some states. I can imagine 'regs' very well, but I've doubt about the rest. 'current', 'launched'? Again, rather export on demand than in advance. Two additional questions, not directly related to the patch: 1. hypercall_field - why not passing this parameter via a register? Helps in case you have multiple guests running. 2. vpid_cnt - what's the purpose, why writing VPID at all? It's not needed, and not even supported on some CPUs. Jan --VgnVr7abVbaOuT8lwQGaxM5DO8CHkiaI6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlH+oWgACgkQitSsb3rl5xSzRwCguuZbE1rUebH5xqdo/TSR1ha3 MX0Ania0IWNxsGLnYzDN1SqOP+zUqRdz =X8S2 -----END PGP SIGNATURE----- --VgnVr7abVbaOuT8lwQGaxM5DO8CHkiaI6--