From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V69tk-0002rl-Te for qemu-devel@nongnu.org; Sun, 04 Aug 2013 21:47:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V69tf-0003Rb-4c for qemu-devel@nongnu.org; Sun, 04 Aug 2013 21:47:48 -0400 Received: from mail1.windriver.com ([147.11.146.13]:58409) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V69te-0003Om-SE for qemu-devel@nongnu.org; Sun, 04 Aug 2013 21:47:43 -0400 Message-ID: <51FF043B.5070008@windriver.com> Date: Mon, 5 Aug 2013 09:47:39 +0800 From: =?UTF-8?B?IuKAnHRpZWp1bi5jaGVu4oCdIg==?= MIME-Version: 1.0 References: <1375407789-5885-1-git-send-email-tiejun.chen@windriver.com> <51FBB53C.8040708@suse.de> In-Reply-To: <51FBB53C.8040708@suse.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [v2][PATCH 1/1] cpus: use cpu_is_stopped efficiently List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: mtosatti@redhat.com, qemu-devel@nongnu.org On 08/02/2013 09:33 PM, =EF=BF=BD wrote: > Am 02.08.2013 03:43, schrieb Tiejun Chen: >> It makes more sense and simple later. >> >> Signed-off-by: Tiejun Chen >> --- >> v1 -> v2: >> >> To optimize performance slightly, we can reorder the two conditions to >> avoid the non-inline function call if cpu->stopped. > > Patch doesn't apply to qemu.git: next_cpu and cpu_thread_is_idle() use > CPUState since a few weeks and do_vm_stop() changed from void to int. > Please remember to rebase before sending patches. Okay, sorry for this inconvenience. Tiejun > > Thanks, applied to qom-cpu-next (with modified commit message): > https://github.com/afaerber/qemu-cpu/commits/qom-cpu-next > > Andreas >