From: Lei Li <lilei@linux.vnet.ibm.com>
To: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
Cc: aarcange@redhat.com, aliguori@us.ibm.com, quintela@redhat.com,
qemu-devel@nongnu.org, lagarcia@br.ibm.com, pbonzini@redhat.com,
rcj@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 05/12] arch_init: introduce ram_save_local()
Date: Mon, 05 Aug 2013 11:27:43 +0800 [thread overview]
Message-ID: <51FF1BAF.2020102@linux.vnet.ibm.com> (raw)
In-Reply-To: <51FC0B97.5060409@linux.vnet.ibm.com>
On 08/03/2013 03:42 AM, Michael R. Hines wrote:
> On 07/25/2013 04:18 PM, Lei Li wrote:
>> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
>> ---
>> arch_init.c | 32 ++++++++++++++++++++++++++++++++
>> 1 files changed, 32 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch_init.c b/arch_init.c
>> index a418071..7eeb52f 100644
>> --- a/arch_init.c
>> +++ b/arch_init.c
>> @@ -757,6 +757,38 @@ static int ram_page_save(QEMUFile *f)
>> return bytes_sent;
>> }
>>
>> +static int ram_save_local(QEMUFile *f, void *opaque)
>> +{
>> + uint64_t bytes_sent = 0;
>> + uint64_t total_ram_bytes = ram_bytes_total();
>> +
>> + qemu_mutex_lock_ramlist();
>> +
>> + while (total_ram_bytes) {
>> + void *ram;
>> + MemoryRegion *mr;
>> +
>> + bytes_sent = ram_page_save(f);
>> + /* No more ram pages. */
>> + if (bytes_sent == 0) {
>> + return bytes_sent;
>> + }
>> +
>> + mr = last_block_local->mr;
>> + ram = memory_region_get_ram_ptr(mr) + last_offset_local;
>> +
>> + /* DONTNEED the ram page that has already copied. */
>> + qemu_madvise(ram, bytes_sent, QEMU_MADV_DONTNEED);
>> + total_ram_bytes -= bytes_sent;
>> + }
>> +
>> + qemu_mutex_unlock_ramlist();
>> +
>> + qemu_put_be64(f, RAM_SAVE_FLAG_EOS);
>> +
>> + return bytes_sent;
>> +}
>> +
>> static int load_xbzrle(QEMUFile *f, ram_addr_t addr, void *host)
>> {
>> int ret, rc = 0;
>
> You need to create a new private structure "QEMUFileLocal".
>
> Then override f->save_page and point this to your own function.
>
> See migration-rdma.c for an example.
Yes, I am looking at it. :)
>
> - Michael
--
Lei
next prev parent reply other threads:[~2013-08-05 3:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 20:18 [Qemu-devel] [PATCH 0/12 RFC v2] Localhost migration Lei Li
2013-07-25 20:18 ` [Qemu-devel] [PATCH 01/12] migration: export MIG_STATE_xxx flags Lei Li
2013-07-25 20:18 ` [Qemu-devel] [PATCH 02/12] savevm: export qemu_save_device_state() Lei Li
2013-07-25 20:18 ` [Qemu-devel] [PATCH 03/12] rename is_active to is_block_active Lei Li
2013-07-25 20:18 ` [Qemu-devel] [PATCH 04/12] arch_init: introduce ram_page_save() Lei Li
2013-08-02 19:40 ` Michael R. Hines
2013-08-05 2:49 ` Lei Li
2013-07-25 20:18 ` [Qemu-devel] [PATCH 05/12] arch_init: introduce ram_save_local() Lei Li
2013-08-02 19:42 ` Michael R. Hines
2013-08-05 3:27 ` Lei Li [this message]
2013-07-25 20:18 ` [Qemu-devel] [PATCH 06/12] arch_init: add save_local_setup to savevm_ram_handlers Lei Li
2013-08-02 19:43 ` Michael R. Hines
2013-07-25 20:18 ` [Qemu-devel] [PATCH 07/12] savevm: introduce qemu_savevm_local() Lei Li
2013-08-02 19:48 ` Michael R. Hines
2013-08-05 3:02 ` Lei Li
2013-07-25 20:18 ` [Qemu-devel] [PATCH 08/12] savevm: adjust is_ram check in register_savevm_live() Lei Li
2013-07-25 20:18 ` [Qemu-devel] [PATCH 09/12] migration-local: implementation of outgoing part Lei Li
2013-08-02 19:45 ` Michael R. Hines
2013-08-05 3:18 ` Lei Li
2013-07-25 20:18 ` [Qemu-devel] [PATCH 10/12] migration-local: implementation of incoming part Lei Li
2013-07-25 20:18 ` [Qemu-devel] [PATCH 11/12] migration-local: add option to commandline for incoming-local Lei Li
2013-08-02 19:46 ` Michael R. Hines
2013-08-05 3:21 ` Lei Li
2013-07-25 20:18 ` [Qemu-devel] [PATCH 12/12] hmp: add hmp_localhost_migration interface Lei Li
2013-08-02 19:47 ` Michael R. Hines
2013-08-05 3:22 ` Lei Li
2013-07-26 9:41 ` [Qemu-devel] [PATCH 0/12 RFC v2] Localhost migration Paolo Bonzini
2013-08-05 8:56 ` Lei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FF1BAF.2020102@linux.vnet.ibm.com \
--to=lilei@linux.vnet.ibm.com \
--cc=aarcange@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=lagarcia@br.ibm.com \
--cc=mrhines@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rcj@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.