From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Date: Mon, 05 Aug 2013 05:50:03 +0000 Subject: Re: [PATCH] arch: powerpc: kvm: add signed type cast for comparation Message-Id: <51FF3D0B.6050609@asianux.com> List-Id: References: <51ECD203.9050507@asianux.com> <20130805043406.GD19254@iris.ozlabs.ibm.com> In-Reply-To: <20130805043406.GD19254@iris.ozlabs.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Paul Mackerras Cc: Gleb Natapov , pbonzini@redhat.com, agraf@suse.de, Benjamin Herrenschmidt , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, "linuxppc-dev@lists.ozlabs.org" On 08/05/2013 12:34 PM, Paul Mackerras wrote: > On Mon, Jul 22, 2013 at 02:32:35PM +0800, Chen Gang wrote: >> > 'rmls' is 'unsigned long', lpcr_rmls() will return negative number when >> > failure occurs, so it need a type cast for comparing. >> > >> > 'lpid' is 'unsigned long', kvmppc_alloc_lpid() return negative number >> > when failure occurs, so it need a type cast for comparing. >> > >> > >> > Signed-off-by: Chen Gang > Looks right, thanks. > > Acked-by: Paul Mackerras > > Thank you very much. -- Chen Gang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from intranet.asianux.com (intranet.asianux.com [58.214.24.6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 450462C0082 for ; Mon, 5 Aug 2013 15:51:12 +1000 (EST) Message-ID: <51FF3D0B.6050609@asianux.com> Date: Mon, 05 Aug 2013 13:50:03 +0800 From: Chen Gang MIME-Version: 1.0 To: Paul Mackerras Subject: Re: [PATCH] arch: powerpc: kvm: add signed type cast for comparation References: <51ECD203.9050507@asianux.com> <20130805043406.GD19254@iris.ozlabs.ibm.com> In-Reply-To: <20130805043406.GD19254@iris.ozlabs.ibm.com> Content-Type: text/plain; charset=UTF-8 Cc: Gleb Natapov , kvm@vger.kernel.org, agraf@suse.de, kvm-ppc@vger.kernel.org, pbonzini@redhat.com, "linuxppc-dev@lists.ozlabs.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 08/05/2013 12:34 PM, Paul Mackerras wrote: > On Mon, Jul 22, 2013 at 02:32:35PM +0800, Chen Gang wrote: >> > 'rmls' is 'unsigned long', lpcr_rmls() will return negative number when >> > failure occurs, so it need a type cast for comparing. >> > >> > 'lpid' is 'unsigned long', kvmppc_alloc_lpid() return negative number >> > when failure occurs, so it need a type cast for comparing. >> > >> > >> > Signed-off-by: Chen Gang > Looks right, thanks. > > Acked-by: Paul Mackerras > > Thank you very much. -- Chen Gang From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Subject: Re: [PATCH] arch: powerpc: kvm: add signed type cast for comparation Date: Mon, 05 Aug 2013 13:50:03 +0800 Message-ID: <51FF3D0B.6050609@asianux.com> References: <51ECD203.9050507@asianux.com> <20130805043406.GD19254@iris.ozlabs.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , pbonzini@redhat.com, agraf@suse.de, Benjamin Herrenschmidt , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, "linuxppc-dev@lists.ozlabs.org" To: Paul Mackerras Return-path: Received: from intranet.asianux.com ([58.214.24.6]:38010 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753695Ab3HEFvH (ORCPT ); Mon, 5 Aug 2013 01:51:07 -0400 In-Reply-To: <20130805043406.GD19254@iris.ozlabs.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/05/2013 12:34 PM, Paul Mackerras wrote: > On Mon, Jul 22, 2013 at 02:32:35PM +0800, Chen Gang wrote: >> > 'rmls' is 'unsigned long', lpcr_rmls() will return negative number when >> > failure occurs, so it need a type cast for comparing. >> > >> > 'lpid' is 'unsigned long', kvmppc_alloc_lpid() return negative number >> > when failure occurs, so it need a type cast for comparing. >> > >> > >> > Signed-off-by: Chen Gang > Looks right, thanks. > > Acked-by: Paul Mackerras > > Thank you very much. -- Chen Gang