diff for duplicates of <51FF882E.2010709@ti.com> diff --git a/a/1.txt b/N1/1.txt index ce1bc09..8aa2466 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -178,14 +178,14 @@ Few comments inlined. >> + >> + switch (mask) { >> + case IIO_CHAN_INFO_RAW: ->> + if (channel->type == IIO_VOLTAGE) { +>> + if (channel->type = IIO_VOLTAGE) { >> + ret = tmp006_read_measurement(data, TMP006_VOBJECT); >> + if (ret < 0) >> + return ret; >> + *val = (s16) ret; > I would marginally prefer you used sign_extend32 to do this (little > bit clearer what is going on). ->> + } else if (channel->type == IIO_TEMP) { +>> + } else if (channel->type = IIO_TEMP) { >> + ret = tmp006_read_measurement(data, TMP006_TAMBIENT); >> + if (ret < 0) >> + return ret; @@ -198,10 +198,10 @@ here, pls? >> + break; >> + return IIO_VAL_INT; >> + case IIO_CHAN_INFO_SCALE: ->> + if (channel->type == IIO_VOLTAGE) { +>> + if (channel->type = IIO_VOLTAGE) { >> + *val = 0; >> + *val2 = 156250; ->> + } else if (channel->type == IIO_TEMP) { +>> + } else if (channel->type = IIO_TEMP) { >> + *val = 31; >> + *val2 = 250000; >> + } else @@ -424,3 +424,9 @@ Power-down?? Regards, - grygorii + + +_______________________________________________ +lm-sensors mailing list +lm-sensors@lm-sensors.org +http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index 8561fcc..514aef0 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,11 +1,11 @@ "ref\01375136888-19978-1-git-send-email-pmeerw@pmeerw.net\0" "ref\051FE2F54.4050104@kernel.org\0" "From\0Grygorii Strashko <grygorii.strashko@ti.com>\0" - "Subject\0Re: [PATCH] iio: Add tmp006 IR temperature sensor\0" - "Date\0Mon, 5 Aug 2013 14:10:38 +0300\0" + "Subject\0Re: [lm-sensors] [PATCH] iio: Add tmp006 IR temperature sensor\0" + "Date\0Mon, 05 Aug 2013 11:10:38 +0000\0" "To\0Jonathan Cameron <jic23@kernel.org>\0" "Cc\0Peter Meerwald <pmeerw@pmeerw.net>" - <linux-iio@vger.kernel.org> + linux-iio@vger.kernel.org LM Sensors <lm-sensors@lm-sensors.org> Guenter Roeck <linux@roeck-us.net> " Jean Delvare <khali@linux-fr.org>\0" @@ -191,14 +191,14 @@ ">> +\n" ">> +\tswitch (mask) {\n" ">> +\tcase IIO_CHAN_INFO_RAW:\n" - ">> +\t\tif (channel->type == IIO_VOLTAGE) {\n" + ">> +\t\tif (channel->type = IIO_VOLTAGE) {\n" ">> +\t\t\tret = tmp006_read_measurement(data, TMP006_VOBJECT);\n" ">> +\t\t\tif (ret < 0)\n" ">> +\t\t\t\treturn ret;\n" ">> +\t\t\t*val = (s16) ret;\n" "> I would marginally prefer you used sign_extend32 to do this (little\n" "> bit clearer what is going on).\n" - ">> +\t\t} else if (channel->type == IIO_TEMP) {\n" + ">> +\t\t} else if (channel->type = IIO_TEMP) {\n" ">> +\t\t\tret = tmp006_read_measurement(data, TMP006_TAMBIENT);\n" ">> +\t\t\tif (ret < 0)\n" ">> +\t\t\t\treturn ret;\n" @@ -211,10 +211,10 @@ ">> +\t\t\tbreak;\n" ">> +\t\treturn IIO_VAL_INT;\n" ">> +\tcase IIO_CHAN_INFO_SCALE:\n" - ">> +\t\tif (channel->type == IIO_VOLTAGE) {\n" + ">> +\t\tif (channel->type = IIO_VOLTAGE) {\n" ">> +\t\t\t*val = 0;\n" ">> +\t\t\t*val2 = 156250;\n" - ">> +\t\t} else if (channel->type == IIO_TEMP) {\n" + ">> +\t\t} else if (channel->type = IIO_TEMP) {\n" ">> +\t\t\t*val = 31;\n" ">> +\t\t\t*val2 = 250000;\n" ">> +\t\t} else\n" @@ -436,6 +436,12 @@ ">\n" "\n" "Regards,\n" - - grygorii + "- grygorii\n" + "\n" + "\n" + "_______________________________________________\n" + "lm-sensors mailing list\n" + "lm-sensors@lm-sensors.org\n" + http://lists.lm-sensors.org/mailman/listinfo/lm-sensors -e3f8873d53a758e5a13ab0239b3f4a0ce8cb775324aac288a2aed30a49e64103 +5c382f4863b6a3de505b30b058068af8dea1cb93980accc77de14a912852482b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.