From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56976)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V6JYQ-0001bD-Q9
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 08:06:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V6JYL-0002ZS-TZ
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 08:06:26 -0400
Message-ID: <51FF952F.3060307@suse.de>
Date: Mon, 05 Aug 2013 14:06:07 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <51F79CD8.7070807@siemens.com>
	<1375464135-29543-1-git-send-email-afaerber@suse.de>
In-Reply-To: <1375464135-29543-1-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-1.6] target-i386: Fix X86CPU error
	handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Igor Mammedov <imammedo@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, qemu-stable@nongnu.org

Am 02.08.2013 19:22, schrieb Andreas F=C3=A4rber:
> Error **errp argument is not for emitting warnings, it means an error
> has occurred and the caller should not make any assumptions about the
> state of other return values (unless otherwise documented).
>=20
> Therefore cpu_x86_create() must unref the new X86CPU itself, and
> pc_new_cpu() must check for an Error rather than NULL return value.
>=20
> While at it, clean up a superfluous NULL check.
>=20
> Reported-by: Jan Kiszka <jan.kiszka@siemens.com>
> Cc: qemu-stable@nongnu.org
> Cc: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>

Ping! Jan, does this address your concerns / use cases?
-rc2 is on Wednesday.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg