From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 05 Aug 2013 15:18:35 +0200 (CEST) Received: from multi.imgtec.com ([194.200.65.239]:15563 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6823064Ab3HENSUGW5cT (ORCPT ); Mon, 5 Aug 2013 15:18:20 +0200 Message-ID: <51FFA5CD.3010406@imgtec.com> Date: Mon, 5 Aug 2013 14:17:01 +0100 From: James Hogan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: David Daney CC: , , , Sanjay Lal , Gleb Natapov , , David Daney Subject: Re: [PATCH 1/3] mips/kvm: Improve code formatting in arch/mips/kvm/kvm_locore.S References: <1375388555-4045-1-git-send-email-ddaney.cavm@gmail.com> <1375388555-4045-2-git-send-email-ddaney.cavm@gmail.com> In-Reply-To: <1375388555-4045-2-git-send-email-ddaney.cavm@gmail.com> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.65] X-SEF-Processed: 7_3_0_01192__2013_08_05_14_18_14 Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 37428 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: james.hogan@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Hi David, On 01/08/13 21:22, David Daney wrote: > From: David Daney > > No code changes, just reflowing some comments and consistently using > tabs and spaces. Object code is verified to be unchanged. > > Signed-off-by: David Daney > Acked-by: Ralf Baechle > + /* Put the saved pointer to vcpu (s1) back into the DDATA_LO Register */ git am detects a whitespace error here ("space before tab in indent"). It's got spaces before and after the tab actually. > /* load the guest context from VCPU and return */ this comment could have it's indentation fixed too Otherwise, for all 3 patches: Reviewed-by: James Hogan Thanks James From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from multi.imgtec.com ([194.200.65.239]:15563 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6823064Ab3HENSUGW5cT (ORCPT ); Mon, 5 Aug 2013 15:18:20 +0200 Message-ID: <51FFA5CD.3010406@imgtec.com> Date: Mon, 5 Aug 2013 14:17:01 +0100 From: James Hogan MIME-Version: 1.0 Subject: Re: [PATCH 1/3] mips/kvm: Improve code formatting in arch/mips/kvm/kvm_locore.S References: <1375388555-4045-1-git-send-email-ddaney.cavm@gmail.com> <1375388555-4045-2-git-send-email-ddaney.cavm@gmail.com> In-Reply-To: <1375388555-4045-2-git-send-email-ddaney.cavm@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: David Daney Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, kvm@vger.kernel.org, Sanjay Lal , Gleb Natapov , linux-kernel@vger.kernel.org, David Daney Message-ID: <20130805131701.HvTukexqKg0cvKHSnnCP1pBhLTxC6tT0kFAD8bHVZUE@z> Hi David, On 01/08/13 21:22, David Daney wrote: > From: David Daney > > No code changes, just reflowing some comments and consistently using > tabs and spaces. Object code is verified to be unchanged. > > Signed-off-by: David Daney > Acked-by: Ralf Baechle > + /* Put the saved pointer to vcpu (s1) back into the DDATA_LO Register */ git am detects a whitespace error here ("space before tab in indent"). It's got spaces before and after the tab actually. > /* load the guest context from VCPU and return */ this comment could have it's indentation fixed too Otherwise, for all 3 patches: Reviewed-by: James Hogan Thanks James