From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv1] arm: armada: Add .dts file for Netgear ReadyNAS 102
Date: Mon, 05 Aug 2013 15:25:21 +0200 [thread overview]
Message-ID: <51FFA7C1.1050103@free-electrons.com> (raw)
In-Reply-To: <878v1mgh4x.fsf@natisbad.org>
On 04/07/2013 23:16, Arnaud Ebalard wrote:
>
> All hardware parts of the (Armada 370 based) NETGEAR ReadyNAS 102 are
> supported by mainline kernel (USB 3.0 rear ports, USB 2.0 front port,
> Gigabit controller and PHY, serial port, leds, buttons, SATA ports,
> G762 fan controller) except for:
>
> - the Intersil ISL12057 I2C RTC Chip,
> - the Armada NAND controller.
>
> Support for both of those is currently work in progress and does not
> prevent boot.
If it is not too late you can add my
Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Just a nitpick:
For a better coherency in your file you could add an extra line before
each sub-node as you have done for all the other nodes:
> + gpio_keys {
> + compatible = "gpio-keys";
> + #address-cells = <1>;
> + #size-cells = <0>;
Here
> + button at 1 {
> + label = "Power Button";
> + linux,code = <116>; /* KEY_POWER */
> + gpios = <&gpio1 30 1>;
> + };
Here
> + button at 2 {
> + label = "Reset Button";
> + linux,code = <0x198>; /* KEY_RESTART */
> + gpios = <&gpio0 6 1>;
> + };
and here
> + button at 3 {
> + label = "Backup Button";
> + linux,code = <133>; /* KEY_COPY */
> + gpios = <&gpio1 26 1>;
> + };
> + };
> +
> +};
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-08-05 13:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 21:16 [PATCHv1] arm: armada: Add .dts file for Netgear ReadyNAS 102 Arnaud Ebalard
2013-07-05 14:29 ` Jason Cooper
2013-07-06 9:00 ` Arnaud Ebalard
2013-07-06 13:38 ` Jason Cooper
2013-07-25 18:41 ` Jason Cooper
2013-08-05 13:25 ` Gregory CLEMENT [this message]
2013-08-05 13:44 ` Jason Cooper
2013-08-05 18:35 ` Arnaud Ebalard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FFA7C1.1050103@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.