From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 05 Aug 2013 18:52:51 +0200 (CEST) Received: from mail-bn1lp0150.outbound.protection.outlook.com ([207.46.163.150]:22741 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S6824790Ab3HEQwhdSz7B (ORCPT ); Mon, 5 Aug 2013 18:52:37 +0200 Received: from BN1PRD0712HT003.namprd07.prod.outlook.com (10.255.196.36) by BLUPR07MB212.namprd07.prod.outlook.com (10.242.200.152) with Microsoft SMTP Server (TLS) id 15.0.731.16; Mon, 5 Aug 2013 16:52:29 +0000 Received: from dl.caveonetworks.com (64.2.3.195) by pod51018.outlook.com (10.255.196.36) with Microsoft SMTP Server (TLS) id 14.16.341.1; Mon, 5 Aug 2013 16:52:27 +0000 Message-ID: <51FFD848.6050104@caviumnetworks.com> Date: Mon, 5 Aug 2013 09:52:24 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Gleb Natapov CC: Ralf Baechle , James Hogan , David Daney , , , Sanjay Lal , , David Daney Subject: Re: [PATCH 1/3] mips/kvm: Improve code formatting in arch/mips/kvm/kvm_locore.S References: <1375388555-4045-1-git-send-email-ddaney.cavm@gmail.com> <1375388555-4045-2-git-send-email-ddaney.cavm@gmail.com> <51FFA5CD.3010406@imgtec.com> <20130805132157.GB3470@linux-mips.org> <20130805134326.GA15901@redhat.com> In-Reply-To: <20130805134326.GA15901@redhat.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.195] X-Forefront-PRVS: 0929F1BAED X-Forefront-Antispam-Report: SFV:NSPM;SFS:(377454003)(479174003)(199002)(189002)(24454002)(51704005)(81542001)(80976001)(66066001)(50986001)(59896001)(74366001)(33656001)(47776003)(47976001)(74876001)(46102001)(76786001)(81342001)(54316002)(16406001)(59766001)(36756003)(19580395003)(80316001)(53806001)(76796001)(64126003)(77982001)(56776001)(74706001)(65956001)(56816003)(80022001)(76482001)(19580405001)(74662001)(54356001)(50466002)(65806001)(49866001)(63696002)(4396001)(47446002)(77096001)(51856001)(69226001)(53416003)(83072001)(47736001)(23756003)(83322001)(74502001)(31966008)(79102001);DIR:OUT;SFP:;SCL:1;SRVR:BLUPR07MB212;H:BN1PRD0712HT003.namprd07.prod.outlook.com;CLIP:64.2.3.195;RD:InfoNoRecords;A:1;MX:1;LANG:en; X-OriginatorOrg: DuplicateDomain-a3ec847f-e37f-4d9a-9900-9d9d96f75f58.caviumnetworks.com Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 37432 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ddaney@caviumnetworks.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 08/05/2013 06:43 AM, Gleb Natapov wrote: > On Mon, Aug 05, 2013 at 03:21:57PM +0200, Ralf Baechle wrote: >> On Mon, Aug 05, 2013 at 02:17:01PM +0100, James Hogan wrote: >> >>> >>> On 01/08/13 21:22, David Daney wrote: >>>> From: David Daney >>>> >>>> No code changes, just reflowing some comments and consistently using >>>> tabs and spaces. Object code is verified to be unchanged. >>>> >>>> Signed-off-by: David Daney >>>> Acked-by: Ralf Baechle >>> >>> >>>> + /* Put the saved pointer to vcpu (s1) back into the DDATA_LO Register */ >>> >>> git am detects a whitespace error here ("space before tab in indent"). >>> It's got spaces before and after the tab actually. >>> >>>> /* load the guest context from VCPU and return */ >>> >>> this comment could have it's indentation fixed too >>> >>> Otherwise, for all 3 patches: >>> >>> Reviewed-by: James Hogan >> >> I'm happy with the patch series as well and will fix this issue when >> applying the patch. >> > kvm fixes usually go through kvm.git tree for all arches. Any special > reasons you want to get those through mips tree? > I don't really care which tree takes this particular patch set. However, in the near future, I will be sending revised versions of patches needed by MIPS/KVM that are in files outside of the arch/mips/kvm directory and it is possible that those may suffer patch ordering problems if merged through a 'foreign tree'. In any event, there is the problem with the whitespace error in the comment. I blame checkpatch.pl for not flagging it, but that is not really a good excuse. If it goes by the KVM tree, do you want me to send a corrected patch? Or can you fix it when you merge it. David Daney From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-bn1lp0150.outbound.protection.outlook.com ([207.46.163.150]:22741 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S6824790Ab3HEQwhdSz7B (ORCPT ); Mon, 5 Aug 2013 18:52:37 +0200 Message-ID: <51FFD848.6050104@caviumnetworks.com> Date: Mon, 5 Aug 2013 09:52:24 -0700 From: David Daney MIME-Version: 1.0 Subject: Re: [PATCH 1/3] mips/kvm: Improve code formatting in arch/mips/kvm/kvm_locore.S References: <1375388555-4045-1-git-send-email-ddaney.cavm@gmail.com> <1375388555-4045-2-git-send-email-ddaney.cavm@gmail.com> <51FFA5CD.3010406@imgtec.com> <20130805132157.GB3470@linux-mips.org> <20130805134326.GA15901@redhat.com> In-Reply-To: <20130805134326.GA15901@redhat.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Gleb Natapov Cc: Ralf Baechle , James Hogan , David Daney , linux-mips@linux-mips.org, kvm@vger.kernel.org, Sanjay Lal , linux-kernel@vger.kernel.org, David Daney Message-ID: <20130805165224.pfrglxNpHOfx3c3YTYYquU_dFOUoZWc6i03XeF-PgWY@z> On 08/05/2013 06:43 AM, Gleb Natapov wrote: > On Mon, Aug 05, 2013 at 03:21:57PM +0200, Ralf Baechle wrote: >> On Mon, Aug 05, 2013 at 02:17:01PM +0100, James Hogan wrote: >> >>> >>> On 01/08/13 21:22, David Daney wrote: >>>> From: David Daney >>>> >>>> No code changes, just reflowing some comments and consistently using >>>> tabs and spaces. Object code is verified to be unchanged. >>>> >>>> Signed-off-by: David Daney >>>> Acked-by: Ralf Baechle >>> >>> >>>> + /* Put the saved pointer to vcpu (s1) back into the DDATA_LO Register */ >>> >>> git am detects a whitespace error here ("space before tab in indent"). >>> It's got spaces before and after the tab actually. >>> >>>> /* load the guest context from VCPU and return */ >>> >>> this comment could have it's indentation fixed too >>> >>> Otherwise, for all 3 patches: >>> >>> Reviewed-by: James Hogan >> >> I'm happy with the patch series as well and will fix this issue when >> applying the patch. >> > kvm fixes usually go through kvm.git tree for all arches. Any special > reasons you want to get those through mips tree? > I don't really care which tree takes this particular patch set. However, in the near future, I will be sending revised versions of patches needed by MIPS/KVM that are in files outside of the arch/mips/kvm directory and it is possible that those may suffer patch ordering problems if merged through a 'foreign tree'. In any event, there is the problem with the whitespace error in the comment. I blame checkpatch.pl for not flagging it, but that is not really a good excuse. If it goes by the KVM tree, do you want me to send a corrected patch? Or can you fix it when you merge it. David Daney