From: Krzysztof Kozlowski <krzk@kernel.org>
To: srinivas.kandagatla@linaro.org, peda@axentia.se,
broonie@kernel.org, andersson@kernel.org, krzk+dt@kernel.org
Cc: ivprusov@salutedevices.com, luca.ceresoli@bootlin.com,
zhoubinbin@loongson.cn, paulha@opensource.cirrus.com,
lgirdwood@gmail.com, robh@kernel.org, conor+dt@kernel.org,
konradybcio@kernel.org, perex@perex.cz, tiwai@suse.com,
dmitry.baryshkov@oss.qualcomm.com, linux-sound@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, johan+linaro@kernel.org
Subject: Re: [PATCH v2 5/5] arm64: dts: qcom: x1e78100-t14s: Enable audio headset support
Date: Fri, 21 Mar 2025 10:30:43 +0100 [thread overview]
Message-ID: <51a40f06-caa0-49bd-a64d-5249dd50445e@kernel.org> (raw)
In-Reply-To: <20250320115633.4248-6-srinivas.kandagatla@linaro.org>
On 20/03/2025 12:56, srinivas.kandagatla@linaro.org wrote:
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
> index b2c2347f54fa..b40775c20493 100644
> --- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
> @@ -19,6 +19,16 @@ / {
> compatible = "lenovo,thinkpad-t14s", "qcom,x1e78100", "qcom,x1e80100";
> chassis-type = "laptop";
>
> + /* two muxes together support CTIA and OMTP switching */
> + us_euro_mux_ctrl: mux-controller {
This goes somewhere after audio-codec, because nodes are ordered by node
name.
> + compatible = "gpio-mux";
> + pinctrl-0 = <&us_euro_hs_sel>;
> + pinctrl-names = "default";
> + mux-supply = <&vreg_l16b_2p5>;
> + #mux-control-cells = <0>;
> + mux-gpios = <&tlmm 68 GPIO_ACTIVE_HIGH>;
> + };
> +
With placement fixed:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
prev parent reply other threads:[~2025-03-21 9:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 11:56 [PATCH v2 0/5] ASoC: wcd938x: enable t14s audio headset srinivas.kandagatla
2025-03-20 11:56 ` [PATCH v2 1/5] dt-bindings: mux: add optional regulator binding to gpio mux srinivas.kandagatla
2025-03-21 9:28 ` Krzysztof Kozlowski
2025-03-20 11:56 ` [PATCH v2 2/5] mux: gpio: add optional regulator support srinivas.kandagatla
2025-03-20 12:16 ` Maud Spierings
2025-03-21 9:27 ` Krzysztof Kozlowski
2025-03-20 11:56 ` [PATCH v2 3/5] ASoC: dt-bindings: wcd93xx: add bindings for audio mux controlling hp srinivas.kandagatla
2025-03-21 9:29 ` Krzysztof Kozlowski
2025-03-21 12:29 ` Srinivas Kandagatla
2025-03-21 22:00 ` Rob Herring
2025-03-20 11:56 ` [PATCH v2 4/5] ASoC: codecs: wcd938x: add mux control support for hp audio mux srinivas.kandagatla
2025-03-20 14:03 ` Dmitry Baryshkov
2025-03-21 12:35 ` Srinivas Kandagatla
2025-03-21 13:16 ` Dmitry Baryshkov
2025-03-21 13:26 ` Srinivas Kandagatla
2025-03-21 16:34 ` Dmitry Baryshkov
2025-03-21 14:14 ` Srinivas Kandagatla
2025-03-21 17:16 ` Dmitry Baryshkov
2025-03-20 15:02 ` Christopher Obbard
2025-03-20 11:56 ` [PATCH v2 5/5] arm64: dts: qcom: x1e78100-t14s: Enable audio headset support srinivas.kandagatla
2025-03-20 13:58 ` Dmitry Baryshkov
2025-03-20 14:59 ` Christopher Obbard
2025-03-21 9:30 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51a40f06-caa0-49bd-a64d-5249dd50445e@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=ivprusov@salutedevices.com \
--cc=johan+linaro@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=paulha@opensource.cirrus.com \
--cc=peda@axentia.se \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.