From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B99EC52D7C for ; Thu, 15 Aug 2024 13:03:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8CB3E10E0A4; Thu, 15 Aug 2024 13:03:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="mUeEPhYj"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8514910E028; Thu, 15 Aug 2024 08:37:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fS+Ia4UM+I2tTgaoG2DZUFNTzlzvvhStumNeJ1V63Bs=; b=mUeEPhYjPNq6RoCiZYR5s6KPxZ G57Sr1tXluPKPcjbj6JahpBS1lbsOfA5tSvJDXMAEHBwHux9jZluhslOWlrPI+sok4RYj7UgeRZ6o w90ozAfUNooP61Ao8bYrQqc4hm7T2m0YeV6mPjutZkQCHfHkspsNreE2M+Qxeh09Lg8Nciq0eUF3c wyln+YQXFbDm/UQI/f9g7UdThRdZgAdBk3ofQmdge68wkAiS/dwLbca1LUfIdpe3Eid4PWNre4nH3 DjKNFFmhK7wakgvp5XOZBPK8hGvF3IDAQF+LMEsYqlGSVJdMyZaNt0bxsIo2x7UcCKZuBK1XvWRUD OVirrxgg==; Received: from [84.69.19.168] (helo=[192.168.0.101]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1seVzB-000UW2-Cs; Thu, 15 Aug 2024 10:37:32 +0200 Message-ID: <51bb99fd-4f50-41b0-836d-69606c50321c@igalia.com> Date: Thu, 15 Aug 2024 09:37:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] Documentation/gpu: Document the situation with unqualified drm-memory- To: Rob Clark , Tvrtko Ursulin Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kernel-dev@igalia.com, Alex Deucher , Rob Clark , =?UTF-8?Q?Christian_K=C3=B6nig?= References: <20240813135712.82611-1-tursulin@igalia.com> <20240813135712.82611-2-tursulin@igalia.com> Content-Language: en-GB From: Tvrtko Ursulin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Thu, 15 Aug 2024 13:03:23 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On 13/08/2024 19:47, Rob Clark wrote: > On Tue, Aug 13, 2024 at 6:57 AM Tvrtko Ursulin wrote: >> >> From: Tvrtko Ursulin >> >> Currently it is not well defined what is drm-memory- compared to other >> categories. >> >> In practice the only driver which emits these keys is amdgpu and in them >> exposes the current resident buffer object memory (including shared). >> >> To prevent any confusion, document that drm-memory- is deprecated and an >> alias for drm-resident-memory-. >> >> While at it also clarify that the reserved sub-string 'memory' refers to >> the memory region component, and also clarify the intended semantics of >> other memory categories. >> >> v2: >> * Also mark drm-memory- as deprecated. >> * Add some more text describing memory categories. (Alex) >> >> v3: >> * Semantics of the amdgpu drm-memory is actually as drm-resident. >> >> Signed-off-by: Tvrtko Ursulin >> Cc: Alex Deucher >> Cc: Christian König >> Cc: Rob Clark > > Reviewed-by: Rob Clark Thanks! So this one is stand alone and could be pushed to drm-misc-next. 2/2 can wait for AMD to give a verdict. Regards, Tvrtko > >> --- >> Documentation/gpu/drm-usage-stats.rst | 25 ++++++++++++++++++++++--- >> 1 file changed, 22 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/gpu/drm-usage-stats.rst b/Documentation/gpu/drm-usage-stats.rst >> index a80f95ca1b2f..ff964c707754 100644 >> --- a/Documentation/gpu/drm-usage-stats.rst >> +++ b/Documentation/gpu/drm-usage-stats.rst >> @@ -144,7 +144,9 @@ Memory >> >> Each possible memory type which can be used to store buffer objects by the >> GPU in question shall be given a stable and unique name to be returned as the >> -string here. The name "memory" is reserved to refer to normal system memory. >> +string here. >> + >> +The region name "memory" is reserved to refer to normal system memory. >> >> Value shall reflect the amount of storage currently consumed by the buffer >> objects belong to this client, in the respective memory region. >> @@ -152,6 +154,9 @@ objects belong to this client, in the respective memory region. >> Default unit shall be bytes with optional unit specifiers of 'KiB' or 'MiB' >> indicating kibi- or mebi-bytes. >> >> +This key is deprecated and is an alias for drm-resident-. Only one of >> +the two should be present in the output. >> + >> - drm-shared-: [KiB|MiB] >> >> The total size of buffers that are shared with another file (e.g., have more >> @@ -159,20 +164,34 @@ than a single handle). >> >> - drm-total-: [KiB|MiB] >> >> -The total size of buffers that including shared and private memory. >> +The total size of all created buffers including shared and private memory. The >> +backing store for the buffers does not have to be currently instantiated to be >> +counted under this category. >> >> - drm-resident-: [KiB|MiB] >> >> -The total size of buffers that are resident in the specified region. >> +The total size of buffers that are resident (have their backing store present or >> +instantiated) in the specified region. >> + >> +This is an alias for drm-memory- and only one of the two should be >> +present in the output. >> >> - drm-purgeable-: [KiB|MiB] >> >> The total size of buffers that are purgeable. >> >> +For example drivers which implement a form of 'madvise' like functionality can >> +here count buffers which have instantiated backing store, but have been marked >> +with an equivalent of MADV_DONTNEED. >> + >> - drm-active-: [KiB|MiB] >> >> The total size of buffers that are active on one or more engines. >> >> +One practical example of this can be presence of unsignaled fences in an GEM >> +buffer reservation object. Therefore the active category is a subset of >> +resident. >> + >> Implementation Details >> ====================== >> >> -- >> 2.44.0 >>