All of lore.kernel.org
 help / color / mirror / Atom feed
From: Reinette Chatre <reinette.chatre@intel.com>
To: "Moger, Babu" <bmoger@amd.com>, Borislav Petkov <bp@alien8.de>,
	Babu Moger <babu.moger@amd.com>
Cc: "Luck, Tony" <tony.luck@intel.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"Dave.Martin@arm.com" <Dave.Martin@arm.com>,
	"james.morse@arm.com" <james.morse@arm.com>,
	"corbet@lwn.net" <corbet@lwn.net>,
	"skhan@linuxfoundation.org" <skhan@linuxfoundation.org>,
	"tglx@kernel.org" <tglx@kernel.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"Eranian, Stephane" <eranian@google.com>,
	"peternewman@google.com" <peternewman@google.com>
Subject: Re: [PATCH 1/2] x86/resctrl, Documentation: Keep mbm_assign_mode "default" on boot
Date: Tue, 4 Aug 2026 22:03:25 -0700	[thread overview]
Message-ID: <51cb5110-d55f-47ab-9fc5-78e36416a550@intel.com> (raw)
In-Reply-To: <b067caec-4e20-4095-a7b4-eecb5d8594c2@amd.com>

Hi Babu,

On 8/4/26 4:44 PM, Moger, Babu wrote:
> Hi Reinette,
> 
> On 8/4/2026 5:10 PM, Reinette Chatre wrote:
>> Hi Boris and Babu,
>>
>> On 8/4/26 12:16 PM, Borislav Petkov wrote:
>>> On Sat, Aug 01, 2026 at 04:47:01PM -0700, Reinette Chatre wrote:
>>>> ...
>>>> On Intel the RMIDs are always counting. Please keep in mind that these RMID do not
>>>> actually return raw counts that are verbatim passed on to user space but instead
>>>> the returned value is "upscaled" using a hardware provided scaling factor to obtain the
>>>> value that is returned to user space. This is done on AMD (with and without ABMC)
>>>> and Intel.
>>>
>>> So, long story short - and I appreciate the explaining - we should switch
>>> AMD's default behavior back to RMID + 64 counters - exactly like it is on
>>> Intel - and the ABMC thing will be explicitly selectable by the user.
>>
>> nit: s/exactly like it is on Intel//
>>
>> ok.
>>
>>> This way there are no surprises when running any tools on either vendor and if
>>> one wants something special, one selects it.
>> This patch, once minimized for easier backporting and marked for stable, would
>> accomplish this.
>>
>> Two nitpicks:
>> * "no surprises" should be "no surprises (as long as AMD hardware does not return
>>    "Unavailable")".
>>     There is the known issue with the default mode on AMD where return of "Unavailable"
>>     is treated as wraparound by pqos.
>> * "one wants something special" should be "one wants accurate data".
>>     Caveat: User does not know how inaccurate data is in default mode. Users need to learn
>>     about existence of accurate data from outside resctrl via external sources, possibly
>>     leaving it up to the tools considered here.
> 
> I can capture these limitations in the documentation(resctrl.rst).
> Is that what you're suggesting?

Are you referring to the nitpicks? I am not suggesting that you take any action based on it.
I quoted text in a message that I do not 100% agree with and highlighted why. My goal for
doing this was just to confirm we are all on the same page.

>> What is the plan with https://github.com/intel/intel-cmt-cat/issues/311 ?
> 
> I see a few possible options:
> 
> 1. Use a workaround by mounting resctrl, setting mbm_assign_mode to default, and rerunning pqos. We can also document this limitation(Unavailable).
> 
> 2. Reference the commit ID once the patch is merged.
> 
> 3. Reach out to the pqos maintainers to explore any other available options.
> 

The end goal is not clear to me here. Without having a goal it is difficult to
explore steps to get there.

One goal mentioned in changelog is to ensure pqos users have a great experience
when using pqos on AMD hardware. Do you expect that pqos users may want to use
assignable counters to get accurate data? If so, is there a plan for these pqos
users to be able to use assignable counters via pqos? 

I do not see mention of a goal or expectation in that issue and as it is written
I interpret it as "enabling assignable counters on AMD is a bug". This interpretation
is supported by the options you list above.
To me this contradicts a goal of supporting pqos users on AMD hardware.

>> sidenote:
>> Separate from this I again would like to propose that AMD work with pqos folks on
>> how pqos should handle the various text return values to fix the wraparound
>> issue. For example, is the preference for counting to stall at a number until the
>> hardware reports data again (so that user space always just sees numbers and not
>> be surprised by text) or should the text value (for example "Unavailable") be passed
>> on to user space or ...? The current wraparound issue should be fixed but it is
>> difficult for me to gauge what solution users would find least surprising. My
>> expectations from users do seem to be on the high side.
>>
> 
> Yes, this has been a longstanding issue on AMD platforms. So far, we
> haven't found a viable solution. Hopefully, AMD will eventually
> provide support for all the counters that are advertised as
> supported.

I'm confused. Are you saying that you have not found a viable solution for
the pqos wraparound issue? But .... you did not even report it to the pqos
team! Are you really suggesting that the fix requires a new AMD hardware feature?
In the mean time software can address it, no? 
Reinette

  reply	other threads:[~2026-08-05  5:03 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17 21:13 [PATCH 1/2] x86/resctrl, Documentation: Keep mbm_assign_mode "default" on boot Babu Moger
2026-07-17 21:13 ` [PATCH 2/2] x86/resctrl: Fix ABMC counter programming for extended counter ranges Babu Moger
2026-07-17 22:56 ` [PATCH 1/2] x86/resctrl, Documentation: Keep mbm_assign_mode "default" on boot Reinette Chatre
2026-07-20 17:00   ` Babu Moger
2026-07-20 18:27     ` Reinette Chatre
2026-07-20 19:15       ` Babu Moger
2026-07-21 20:54         ` Reinette Chatre
2026-07-23 18:03           ` Babu Moger
2026-07-23 21:46             ` Reinette Chatre
2026-07-24 20:57               ` Moger, Babu
2026-07-24 22:28                 ` Reinette Chatre
2026-07-24 23:12                   ` Borislav Petkov
2026-07-24 23:53                     ` Reinette Chatre
2026-07-27 14:05                       ` Borislav Petkov
2026-07-27 15:25                         ` Reinette Chatre
2026-07-27 17:24                           ` Babu Moger
2026-07-27 18:12                             ` Reinette Chatre
2026-07-27 20:17                               ` Babu Moger
2026-07-27 21:42                                 ` Reinette Chatre
2026-07-27 22:44                                   ` Moger, Babu
2026-07-27 23:29                                     ` Moger, Babu
2026-07-28  0:29                                       ` Reinette Chatre
2026-07-28 17:04                                         ` Borislav Petkov
2026-07-28 17:25                                         ` Babu Moger
2026-07-20 20:12 ` Babu Moger
2026-07-28 19:18 ` Borislav Petkov
2026-07-28 19:46   ` Babu Moger
2026-07-28 19:58     ` Luck, Tony
2026-07-28 20:18       ` Babu Moger
2026-07-28 20:24         ` Luck, Tony
2026-07-28 20:43           ` Babu Moger
2026-07-28 21:58             ` Reinette Chatre
2026-07-28 22:20               ` Moger, Babu
2026-07-30 18:46                 ` Borislav Petkov
2026-07-30 19:39                   ` Babu Moger
2026-07-30 19:43                     ` Borislav Petkov
2026-07-30 19:49                       ` Babu Moger
2026-07-30 20:40                         ` Luck, Tony
2026-07-30 20:59                           ` Babu Moger
2026-07-31  0:34                           ` Borislav Petkov
2026-07-31 14:59                             ` Reinette Chatre
2026-08-01  1:22                               ` Borislav Petkov
2026-08-01 23:47                                 ` Reinette Chatre
2026-08-04 19:16                                   ` Borislav Petkov
2026-08-04 22:10                                     ` Reinette Chatre
2026-08-04 22:47                                       ` Borislav Petkov
2026-08-04 23:05                                         ` Luck, Tony
2026-08-04 23:40                                           ` Borislav Petkov
2026-08-05  0:02                                             ` Luck, Tony
2026-08-05  0:21                                               ` Borislav Petkov
2026-08-04 23:35                                         ` Reinette Chatre
2026-08-05  0:12                                           ` Reinette Chatre
2026-08-05 22:40                                           ` Moger, Babu
2026-08-31 22:59                                             ` Babu Moger
2026-09-01 19:26                                               ` Reinette Chatre
2026-09-01 23:21                                                 ` Borislav Petkov
2026-09-02  0:21                                                   ` Reinette Chatre
2026-09-02  0:43                                                     ` Borislav Petkov
2026-09-02 15:40                                                     ` Babu Moger
2026-08-04 23:44                                       ` Moger, Babu
2026-08-05  5:03                                         ` Reinette Chatre [this message]
2026-07-31 15:34                             ` Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51cb5110-d55f-47ab-9fc5-78e36416a550@intel.com \
    --to=reinette.chatre@intel.com \
    --cc=Dave.Martin@arm.com \
    --cc=babu.moger@amd.com \
    --cc=bmoger@amd.com \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=eranian@google.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peternewman@google.com \
    --cc=skhan@linuxfoundation.org \
    --cc=tglx@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.