From: Qingfang Deng <qingfang.deng@linux.dev>
To: Eric Dumazet <edumazet@kernel.org>
Cc: netdev-bot+sinfo@kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Breno Leitao <leitao@debian.org>, Kees Cook <kees@kernel.org>,
Taegu Ha <hataegu0826@gmail.com>,
Tom Parkin <tparkin@katalix.com>,
linux-ppp@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
James Chapman <jchapman@katalix.com>,
Sashiko <sashiko-bot@kernel.org>, Felix Fietkau <nbd@nbd.name>,
Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH net] ppp: linearize bridged packets when required
Date: Thu, 22 Oct 2026 01:03:48 +0800 [thread overview]
Message-ID: <51ccddcc-53b0-47cd-9526-ccd825f0f6d9@linux.dev> (raw)
In-Reply-To: <CAL4WiiouaJ5QU24uKt=CuxpfgHmWHS5oxoE2E_C6KFCLbDh0+w@mail.gmail.com>
On 10/22/2026 12:31 AM, Eric Dumazet wrote:
> Le mer. 21 oct. 2026 à 12:27, Qingfang Deng <qingfang.deng@linux.dev> a écrit :
>>> + case PPP_IP:
>>> + skb->protocol = htons(ETH_P_IP);
>>> + break;
>>> + case PPP_IPV6:
>>> + skb->protocol = htons(ETH_P_IPV6);
>>> + break;
>>> + default:
>>> + goto drop;
>>> + }
>>> + skb_set_network_header(skb, PPP_PROTO_LEN);
>>> +
>>> + segs = skb_gso_segment(skb, 0);
>>
>> Passing zero features to skb_gso_segment will linearize every segment
>> prematurely.
>
> Good point, PPTP and L2TP do not need linear packets.
> I will pass NETIF_F_SG: checksums are still computed in software by
> skb_segment(), as openvswitch does, and ppp_bridge_xmit() linearizes
> segments only for channels without direct_xmit.
What about NETIF_F_FRAGLIST?
next prev parent reply other threads:[~2026-10-21 17:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 2:36 [PATCH net] ppp: linearize bridged packets when required Qingfang Deng
2026-10-21 2:39 ` netdev-bot+sinfo
2026-10-21 3:07 ` Qingfang Deng
2026-10-21 9:24 ` Eric Dumazet
2026-10-21 10:27 ` Qingfang Deng
2026-10-21 16:31 ` Eric Dumazet
2026-10-21 17:03 ` Qingfang Deng [this message]
2026-10-21 17:55 ` Eric Dumazet
2026-10-22 2:18 ` Qingfang Deng
2026-10-22 4:05 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ccddcc-53b0-47cd-9526-ccd825f0f6d9@linux.dev \
--to=qingfang.deng@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hataegu0826@gmail.com \
--cc=jchapman@katalix.com \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=netdev-bot+sinfo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=sashiko-bot@kernel.org \
--cc=tparkin@katalix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.