From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 632D7C4167B for ; Tue, 28 Nov 2023 11:18:02 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.643064.1002941 (Exim 4.92) (envelope-from ) id 1r7w68-0008ST-UD; Tue, 28 Nov 2023 11:17:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 643064.1002941; Tue, 28 Nov 2023 11:17:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r7w68-0008SM-R3; Tue, 28 Nov 2023 11:17:48 +0000 Received: by outflank-mailman (input) for mailman id 643064; Tue, 28 Nov 2023 11:17:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r7w67-0008SF-NR for xen-devel@lists.xenproject.org; Tue, 28 Nov 2023 11:17:47 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c114c934-8ddf-11ee-9b0e-b553b5be7939; Tue, 28 Nov 2023 12:17:45 +0100 (CET) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id D43154EE0737; Tue, 28 Nov 2023 12:17:44 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c114c934-8ddf-11ee-9b0e-b553b5be7939 MIME-Version: 1.0 Date: Tue, 28 Nov 2023 12:17:44 +0100 From: Nicola Vetrini To: Jan Beulich Cc: Stefano Stabellini , Andrew Cooper3 , Julien Grall , George Dunlap , Wei Liu , Xen Devel Subject: Re: MISRA: Compatible declarations for sort and bsearch In-Reply-To: <225661f6-fd30-4c28-84af-a6ff16def246@suse.com> References: <225661f6-fd30-4c28-84af-a6ff16def246@suse.com> Message-ID: <51df0275d0988af618c22adb8d55138c@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 2023-11-28 09:56, Jan Beulich wrote: > On 24.11.2023 10:40, Nicola Vetrini wrote: >> in xen/lib.h and xen/sort.h there are definitions of the functions >> bsearch and sort that have no prior declarations, and therefore are >> subject to a violation of MISRA C Rule 8.4. >> >> I'm wondering whether it would be preferred >> >> 1. to put a declaration just before the definition, in lib.h and >> sort.h >> 2. deviate these functions, as their signatures are well-known and >> somewhat standardized > > Seeing that so far no-one else has replied to this: My take is > "neither". > It is the very nature of extern gnu_inline functions to work like this. > This could well be a justification text: violations of required rules need either to be fixed or justified. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)