All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Peter Griffin <peter.griffin@linaro.org>,
	alim.akhtar@samsung.com, James.Bottomley@HansenPartnership.com,
	martin.petersen@oracle.com, krzk@kernel.org
Cc: linux-scsi@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, willmcvicker@google.com,
	tudor.ambarus@linaro.org, andre.draszik@linaro.org,
	ebiggers@kernel.org, kernel-team@android.com
Subject: Re: [PATCH 5/6] scsi: ufs: exynos: Move phy calls to .exit() callback
Date: Fri, 28 Feb 2025 11:20:06 -0800	[thread overview]
Message-ID: <51ec6f40-c62a-418b-a538-082e3ad887cb@acm.org> (raw)
In-Reply-To: <20250226220414.343659-6-peter.griffin@linaro.org>

On 2/26/25 2:04 PM, Peter Griffin wrote:
> +static void exynos_ufs_exit(struct ufs_hba *hba)
> +{
> +	struct exynos_ufs *ufs = ufshcd_get_variant(hba);
> +
> +	phy_power_off(ufs->phy);
> +	phy_exit(ufs->phy);
> +}
> +
> +

For future patches, please follow the convention that is used elsewhere
in the kernel and separate functions with a single blank line instead of
two.


Thanks,

Bart.


  reply	other threads:[~2025-02-28 19:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-26 22:04 [PATCH 0/6] ufs-exynos fixes for gs101 Peter Griffin
2025-02-26 22:04 ` [PATCH 1/6] scsi: ufs: exynos: ensure pre_link() executes before exynos_ufs_phy_init() Peter Griffin
2025-02-26 22:04 ` [PATCH 2/6] scsi: ufs: exynos: move ufs shareability value to drvdata Peter Griffin
2025-02-26 22:04 ` [PATCH 3/6] scsi: ufs: exynos: ensure consistent phy reference counts Peter Griffin
2025-02-26 22:04 ` [PATCH 4/6] scsi: ufs: exynos: Enable PRDT pre-fetching with UFSHCD_CAP_CRYPTO Peter Griffin
2025-02-28 19:18   ` Bart Van Assche
2025-03-04 11:49     ` Peter Griffin
2025-03-05  2:40   ` Eric Biggers
2025-03-07 15:10     ` Peter Griffin
2025-02-26 22:04 ` [PATCH 5/6] scsi: ufs: exynos: Move phy calls to .exit() callback Peter Griffin
2025-02-28 19:20   ` Bart Van Assche [this message]
2025-03-04 11:10     ` Peter Griffin
2025-02-26 22:04 ` [PATCH 6/6] scsi: ufs: exynos: put ufs device in reset on .exit() and .suspend() Peter Griffin
2025-02-28 19:21   ` Bart Van Assche
2025-03-04 11:37     ` Peter Griffin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51ec6f40-c62a-418b-a538-082e3ad887cb@acm.org \
    --to=bvanassche@acm.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alim.akhtar@samsung.com \
    --cc=andre.draszik@linaro.org \
    --cc=ebiggers@kernel.org \
    --cc=kernel-team@android.com \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=peter.griffin@linaro.org \
    --cc=tudor.ambarus@linaro.org \
    --cc=willmcvicker@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.