All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ankit Nautiyal <ankit.k.nautiyal@intel.com>,
	intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jouni.hogander@intel.com, suraj.kandpal@intel.com,
	Ankit Nautiyal <ankit.k.nautiyal@intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Subject: Re: [PATCH] Revert "drm/i915/psr: Allow SCL=0 on platforms with always-on VRR TG"
Date: Thu, 02 Jul 2026 18:50:19 +0300	[thread overview]
Message-ID: <51f6951d566ceda03eb47402904f8fe91c7a9f38@intel.com> (raw)
In-Reply-To: <20260622101736.2389991-1-ankit.k.nautiyal@intel.com>

On Mon, 22 Jun 2026, Ankit Nautiyal <ankit.k.nautiyal@intel.com> wrote:
> This reverts commit 4f1cab2e4863d96ce13b8d94151f4848e38c3d5b.
>
> Allowing SCL=0 on platforms with always-on VRR timing generator is
> causing underruns and other issues on PTL in some cases.
>
> SCL still needs to be non-zero in certain scenarios. Revert for now
> until this is better understood.
>
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

This would've needed

Fixes: 4f1cab2e4863 ("drm/i915/psr: Allow SCL=0 on platforms with always-on VRR TG")

to have it be picked up for v7.2-rc2. Please talk to Joonas to ensure it
gets picked up for -rc3.

BR,
Jani.

> ---
>  drivers/gpu/drm/i915/display/intel_psr.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index 911afb9cb24e..92af21d823a3 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -1405,9 +1405,6 @@ int _intel_psr_min_set_context_latency(const struct intel_crtc_state *crtc_state
>  	    needs_panel_replay)
>  		return 0;
>  
> -	if (intel_vrr_always_use_vrr_tg(display))
> -		return 0;
> -
>  	return 1;
>  }

-- 
Jani Nikula, Intel

  parent reply	other threads:[~2026-07-02 15:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-22 10:17 [PATCH] Revert "drm/i915/psr: Allow SCL=0 on platforms with always-on VRR TG" Ankit Nautiyal
2026-06-22 10:39 ` Kandpal, Suraj
2026-06-22 15:09 ` ✓ i915.CI.BAT: success for " Patchwork
2026-06-22 15:23 ` ✓ CI.KUnit: " Patchwork
2026-06-22 15:59 ` ✓ Xe.CI.BAT: " Patchwork
2026-06-22 18:01 ` ✓ i915.CI.Full: " Patchwork
2026-06-22 18:45 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-06-25  8:16 ` ✓ CI.KUnit: success for Revert "drm/i915/psr: Allow SCL=0 on platforms with always-on VRR TG" (rev2) Patchwork
2026-06-25  8:51 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-06-25 10:09 ` ✗ Xe.CI.FULL: " Patchwork
2026-07-02 15:50 ` Jani Nikula [this message]
2026-07-03  3:14   ` [PATCH] Revert "drm/i915/psr: Allow SCL=0 on platforms with always-on VRR TG" Nautiyal, Ankit K
2026-07-06 18:36     ` Rodrigo Vivi
2026-07-07  2:55       ` Nautiyal, Ankit K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51f6951d566ceda03eb47402904f8fe91c7a9f38@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=jouni.hogander@intel.com \
    --cc=suraj.kandpal@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.