From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: linus.walleij@linaro.org, ian.campbell@citrix.com,
rob.herring@calxeda.com, pawel.moll@arm.com,
mark.rutland@arm.com, rob@landley.net, sameo@linux.intel.com,
lee.jones@linaro.org, grant.likely@linaro.org,
broonie@kernel.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
gg@slimlogic.co.uk, kishon@ti.com
Subject: Re: [PATCH V2 1/3] pinctrl: add utility functions for add map/configs
Date: Mon, 05 Aug 2013 15:37:54 -0600 [thread overview]
Message-ID: <52001B32.7070107@wwwdotorg.org> (raw)
In-Reply-To: <1375688014-6117-2-git-send-email-ldewangan@nvidia.com>
On 08/05/2013 01:33 AM, Laxman Dewangan wrote:
> Some of pincontrol driver needs the utility function to create map
> list. The utility function needed for adding mux, configs etc.
>
> In place of duplicating this in each driver, add the common utility
> function in common file and use from device specific driver. This will
> reduce the duplicating of code across drivers.
This patch,
Reviewed-by: Stephen Warren <swarren@nvidia.com>
Some more documentation mnight be useful though, now these are common
utility functions rather than just some internal functions in the Tegra
pinctrl driver.
Hopefully there will be a patch to convert at least the Tegra pinctrl
driver to use these new functions.
next prev parent reply other threads:[~2013-08-05 21:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 7:33 [PATCH V2 0/3] pinctrl: add pincontrol driver for palmas device Laxman Dewangan
2013-08-05 7:33 ` Laxman Dewangan
2013-08-05 7:33 ` [PATCH V2 1/3] pinctrl: add utility functions for add map/configs Laxman Dewangan
2013-08-05 7:33 ` Laxman Dewangan
2013-08-05 21:37 ` Stephen Warren [this message]
2013-08-06 12:25 ` Laxman Dewangan
2013-08-05 7:33 ` [PATCH V2 2/3] pinctrl: pinconf-generic: add generic APIs for mapping pinctrl node Laxman Dewangan
2013-08-05 7:33 ` Laxman Dewangan
2013-08-05 21:42 ` Stephen Warren
2013-08-05 7:33 ` [PATCH V2 3/3] pinctrl: palmas: add pincontrol driver Laxman Dewangan
2013-08-05 7:33 ` Laxman Dewangan
2013-08-05 7:44 ` Lee Jones
2013-08-05 22:04 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52001B32.7070107@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=kishon@ti.com \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.