From: Romain Naour <romain.naour@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 02/22] toolchain-external: reorder the contents of toolchain-external.mk
Date: Mon, 7 Nov 2016 22:26:32 +0100 [thread overview]
Message-ID: <52005830-4f91-bac6-72ce-e8183448b5bc@gmail.com> (raw)
In-Reply-To: <20161107012017.22505-3-arnout@mind.be>
Hi Arnout,
Le 07/11/2016 ? 02:19, Arnout Vandecappelle (Essensium/Mind) a ?crit :
> When the toolchain-external logic will be split into separate packages,
> the order in which things are defined in toolchain-external.mk no
> makes less sense. So reorder things in a more logical fashion.
>
> Also add a few more comments to the different sections.
>
> No functional changes at all. The output of 'make -qp' hasn't changed,
> except for the order of arguments in
> TOOLCHAIN_EXTERNAL_TOOLCHAIN_WRAPPER_ARGS.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> [Arnout: split off into separate patch, slightly change some comments,
> reordered some parts]
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
I reviewed as carefully as possible, It should be fine.
Reviewed-by: Romain Naour <romain.naour@gmail.com>
Best regards,
Romain
next prev parent reply other threads:[~2016-11-07 21:26 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 1:19 [Buildroot] [PATCH v4 00/22] Splitting the toolchain-external package Arnout Vandecappelle
2016-11-07 1:19 ` [Buildroot] [PATCH v4 01/22] Use already qstripped BR2_TOOLCHAIN_EXTERNAL_PREFIX everywhere Arnout Vandecappelle
2016-11-07 21:06 ` Romain Naour
2016-11-09 21:51 ` Thomas Petazzoni
2016-11-07 1:19 ` [Buildroot] [PATCH v4 02/22] toolchain-external: reorder the contents of toolchain-external.mk Arnout Vandecappelle
2016-11-07 21:26 ` Romain Naour [this message]
2016-11-07 1:19 ` [Buildroot] [PATCH v4 03/22] toolchain-external: move parts to pkg-toolchain-external.mk Arnout Vandecappelle
2016-11-07 21:34 ` Romain Naour
2016-11-07 1:19 ` [Buildroot] [PATCH v4 04/22] toolchain-external: introduce toolchain-external-package Arnout Vandecappelle
2016-11-07 22:16 ` Romain Naour
2016-11-08 1:00 ` Arnout Vandecappelle
2016-11-08 8:20 ` Thomas Petazzoni
2016-11-08 12:30 ` Arnout Vandecappelle
2016-11-08 15:38 ` Thomas Petazzoni
2016-11-08 20:53 ` Arnout Vandecappelle
2016-11-11 11:19 ` Arnout Vandecappelle
2016-11-07 1:20 ` [Buildroot] [PATCH v4 05/22] toolchain-external-linaro-aarch64: new package Arnout Vandecappelle
2016-11-07 22:23 ` Romain Naour
2016-11-07 1:20 ` [Buildroot] [PATCH v4 06/22] toolchain-external-codesourcery-aarch64: " Arnout Vandecappelle
2016-11-07 22:25 ` Romain Naour
2016-11-07 1:20 ` [Buildroot] [PATCH v4 07/22] toolchain-external-linaro-arm: " Arnout Vandecappelle
2016-11-07 22:26 ` Romain Naour
2016-11-07 1:20 ` [Buildroot] [PATCH v4 08/22] toolchain-external-codesourcery-arm: " Arnout Vandecappelle
2016-11-07 22:28 ` Romain Naour
2016-11-07 1:20 ` [Buildroot] [PATCH v4 09/22] toolchain-external-codesourcery-arm: Cortex-A12 and Cortex-A17 not supported Arnout Vandecappelle
2016-11-07 22:35 ` Romain Naour
2016-11-07 1:20 ` [Buildroot] [PATCH v4 10/22] toolchain-external-linaro-armeb: new package Arnout Vandecappelle
2016-11-07 22:37 ` Romain Naour
2016-11-07 1:20 ` [Buildroot] [PATCH v4 11/22] toolchain-external-blackfin-uclinux: " Arnout Vandecappelle
2016-11-07 22:42 ` Romain Naour
2016-11-07 1:20 ` [Buildroot] [PATCH v4 12/22] toolchain-external-codesourcery-mips: " Arnout Vandecappelle
2016-11-07 22:43 ` Romain Naour
2016-11-07 1:20 ` [Buildroot] [PATCH v4 13/22] toolchain-external-codescape-img-mips: " Arnout Vandecappelle
2016-11-22 21:20 ` Romain Naour
2016-11-07 1:20 ` [Buildroot] [PATCH v4 14/22] toolchain-external-codescape-mti-mips: " Arnout Vandecappelle
2016-11-22 21:23 ` Romain Naour
2016-11-07 1:20 ` [Buildroot] [PATCH v4 15/22] toolchain-external-codesourcery-niosII: " Arnout Vandecappelle
2016-11-22 21:30 ` Romain Naour
2016-11-07 1:20 ` [Buildroot] [PATCH v4 16/22] toolchain-external-codesourcery-sh: " Arnout Vandecappelle
2016-11-22 21:32 ` Romain Naour
2016-11-07 1:20 ` [Buildroot] [PATCH v4 17/22] toolchain-external-codesourcery-amd64: " Arnout Vandecappelle
2016-11-22 21:34 ` Romain Naour
2016-11-07 1:20 ` [Buildroot] [PATCH v4 18/22] toolchain-external-codesourcery-x86: " Arnout Vandecappelle
2016-11-22 21:35 ` Romain Naour
2016-11-07 1:20 ` [Buildroot] [PATCH v4 19/22] toolchain-external-musl-cross: " Arnout Vandecappelle
2016-11-22 21:40 ` Romain Naour
2016-11-07 1:20 ` [Buildroot] [PATCH v4 20/22] toolchain-external-custom: " Arnout Vandecappelle
2016-11-22 21:49 ` Romain Naour
2016-11-07 1:20 ` [Buildroot] [PATCH v4 21/22] toolchain-external-arc: " Arnout Vandecappelle
2016-11-22 21:51 ` Romain Naour
2016-11-07 1:20 ` [Buildroot] [PATCH v4 22/22] toolchain-external: remove Arago toolchains Arnout Vandecappelle
2016-11-07 22:49 ` Romain Naour
2016-11-07 9:39 ` [Buildroot] [PATCH v4 00/22] Splitting the toolchain-external package Romain NAOUR
2016-11-23 21:39 ` Thomas Petazzoni
2016-11-23 22:15 ` Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52005830-4f91-bac6-72ce-e8183448b5bc@gmail.com \
--to=romain.naour@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.