From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from [222.73.24.84] (helo=song.cn.fujitsu.com) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1V6cUn-0005Gi-0Y for kexec@lists.infradead.org; Tue, 06 Aug 2013 08:19:58 +0000 Message-ID: <5200B185.9010402@cn.fujitsu.com> Date: Tue, 06 Aug 2013 16:19:17 +0800 From: Zhang Yanfei MIME-Version: 1.0 Subject: Re: [PATCH] kexec: remove unnecessary return References: <5200AE50.2010108@huawei.com> In-Reply-To: <5200AE50.2010108@huawei.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Xishi Qiu Cc: kexec@lists.infradead.org, ebiederm@xmission.com, LKML 5LqOIDIwMTMvOC82IDE2OjA1LCBYaXNoaSBRaXUg5YaZ6YGTOgo+IENvZGUgY2FuIG5vdCBydW4g aGVyZSBmb3JldmVyLCBzbyByZW1vdmUgdGhlIHVubmVjZXNzYXJ5IHJldHVybi4KPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBYaXNoaSBRaXUgPHFpdXhpc2hpQGh1YXdlaS5jb20+Cj4gLS0tCj4gIGtlcm5l bC9rZXhlYy5jIHwgICAgMiAtLQo+ICAxIGZpbGVzIGNoYW5nZWQsIDAgaW5zZXJ0aW9ucygrKSwg MiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEva2VybmVsL2tleGVjLmMgYi9rZXJuZWwv a2V4ZWMuYwo+IGluZGV4IDU5ZjdiNTUuLmMxNGUzZWEgMTAwNjQ0Cj4gLS0tIGEva2VybmVsL2tl eGVjLmMKPiArKysgYi9rZXJuZWwva2V4ZWMuYwo+IEBAIC0xNDc3LDggKzE0NzcsNiBAQCBzdGF0 aWMgaW50IF9faW5pdCBfX3BhcnNlX2NyYXNoa2VybmVsKGNoYXIgKmNtZGxpbmUsCj4gIAllbHNl Cj4gIAkJcmV0dXJuIHBhcnNlX2NyYXNoa2VybmVsX3NpbXBsZShja19jbWRsaW5lLCBjcmFzaF9z aXplLAo+ICAJCQkJY3Jhc2hfYmFzZSk7Cj4gLQo+IC0JcmV0dXJuIDA7Cj4gIH0KPiAgCj4gIC8q Cj4gCgpIaSBYaXNoaSwKCmNoYW5nZQoKMTQ3NCAgICAgICAgIGlmIChmaXJzdF9jb2xvbiAmJiAo IWZpcnN0X3NwYWNlIHx8IGZpcnN0X2NvbG9uIDwgZmlyc3Rfc3BhY2UpKQoxNDc1ICAgICAgICAg ICAgICAgICByZXR1cm4gcGFyc2VfY3Jhc2hrZXJuZWxfbWVtKGNrX2NtZGxpbmUsIHN5c3RlbV9y YW0sCjE0NzYgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjcmFzaF9zaXplLCBjcmFz aF9iYXNlKTsKMTQ3NyAgICAgICAgIGVsc2UKMTQ3OCAgICAgICAgICAgICAgICAgcmV0dXJuIHBh cnNlX2NyYXNoa2VybmVsX3NpbXBsZShja19jbWRsaW5lLCBjcmFzaF9zaXplLAoxNDc5ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgY3Jhc2hfYmFzZSk7CjE0ODAgCjE0ODEgICAgICAg ICByZXR1cm4gMDsKCnRvCgoxNDc0ICAgICAgICAgaWYgKGZpcnN0X2NvbG9uICYmICghZmlyc3Rf c3BhY2UgfHwgZmlyc3RfY29sb24gPCBmaXJzdF9zcGFjZSkpCjE0NzUgICAgICAgICAgICAgICAg IHJldHVybiBwYXJzZV9jcmFzaGtlcm5lbF9tZW0oY2tfY21kbGluZSwgc3lzdGVtX3JhbSwKMTQ3 NiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNyYXNoX3NpemUsIGNyYXNoX2Jhc2Up OwoKMTQ3OCAgICAgICAgIHJldHVybiBwYXJzZV9jcmFzaGtlcm5lbF9zaW1wbGUoY2tfY21kbGlu ZSwgY3Jhc2hfc2l6ZSwgY3Jhc2hfYmFzZSk7CgpzZWVtcyBiZXR0ZXIuCi0tIApUaGFua3MuClpo YW5nIFlhbmZlaQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18Ka2V4ZWMgbWFpbGluZyBsaXN0CmtleGVjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9rZXhlYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754384Ab3HFITX (ORCPT ); Tue, 6 Aug 2013 04:19:23 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:44348 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753315Ab3HFITV convert rfc822-to-8bit (ORCPT ); Tue, 6 Aug 2013 04:19:21 -0400 X-IronPort-AV: E=Sophos;i="4.89,825,1367942400"; d="scan'208";a="8131747" Message-ID: <5200B185.9010402@cn.fujitsu.com> Date: Tue, 06 Aug 2013 16:19:17 +0800 From: Zhang Yanfei User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Xishi Qiu CC: ebiederm@xmission.com, kexec@lists.infradead.org, LKML Subject: Re: [PATCH] kexec: remove unnecessary return References: <5200AE50.2010108@huawei.com> In-Reply-To: <5200AE50.2010108@huawei.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/08/06 16:17:56, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/08/06 16:17:56 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2013/8/6 16:05, Xishi Qiu 写道: > Code can not run here forever, so remove the unnecessary return. > > Signed-off-by: Xishi Qiu > --- > kernel/kexec.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/kernel/kexec.c b/kernel/kexec.c > index 59f7b55..c14e3ea 100644 > --- a/kernel/kexec.c > +++ b/kernel/kexec.c > @@ -1477,8 +1477,6 @@ static int __init __parse_crashkernel(char *cmdline, > else > return parse_crashkernel_simple(ck_cmdline, crash_size, > crash_base); > - > - return 0; > } > > /* > Hi Xishi, change 1474 if (first_colon && (!first_space || first_colon < first_space)) 1475 return parse_crashkernel_mem(ck_cmdline, system_ram, 1476 crash_size, crash_base); 1477 else 1478 return parse_crashkernel_simple(ck_cmdline, crash_size, 1479 crash_base); 1480 1481 return 0; to 1474 if (first_colon && (!first_space || first_colon < first_space)) 1475 return parse_crashkernel_mem(ck_cmdline, system_ram, 1476 crash_size, crash_base); 1478 return parse_crashkernel_simple(ck_cmdline, crash_size, crash_base); seems better. -- Thanks. Zhang Yanfei