From: Younger Liu <younger.liu@huawei.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: fix a memory leak at __ocfs2_move_extents()
Date: Tue, 6 Aug 2013 16:39:21 +0800 [thread overview]
Message-ID: <5200B639.7000303@huawei.com> (raw)
In-Reply-To: <5200968A.1050403@oracle.com>
On 2013/8/6 14:24, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> The ocfs2 path is not properly freed which leads to a
> memory leak at __ocfs2_move_extents().
>
> This patch stops the leaks of the ocfs2_path structure.
>
> Cc: Younger Liu <younger.liu@huawei.com>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
This patch looks fine to me.
Reviewed-by: Younger Liu <younger.liu@huawei.com>
> ---
> fs/ocfs2/move_extents.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/ocfs2/move_extents.c b/fs/ocfs2/move_extents.c
> index f1fc172..37231d1 100644
> --- a/fs/ocfs2/move_extents.c
> +++ b/fs/ocfs2/move_extents.c
> @@ -152,6 +152,7 @@ static int __ocfs2_move_extent(handle_t *handle,
> }
>
> out:
> + ocfs2_free_path(path);
> return ret;
> }
>
>
prev parent reply other threads:[~2013-08-06 8:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 6:24 [Ocfs2-devel] [PATCH] ocfs2: fix a memory leak at __ocfs2_move_extents() Jeff Liu
2013-08-06 8:39 ` Younger Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5200B639.7000303@huawei.com \
--to=younger.liu@huawei.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.