From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from [222.73.24.84] (helo=song.cn.fujitsu.com) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1V6csf-0006Lr-Td for kexec@lists.infradead.org; Tue, 06 Aug 2013 08:44:38 +0000 Message-ID: <5200B75F.6050906@cn.fujitsu.com> Date: Tue, 06 Aug 2013 16:44:15 +0800 From: Zhang Yanfei MIME-Version: 1.0 Subject: Re: [PATCH V2] kexec: remove unnecessary return References: <5200B534.7000202@huawei.com> In-Reply-To: <5200B534.7000202@huawei.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Xishi Qiu Cc: kexec@lists.infradead.org, ebiederm@xmission.com, LKML 5LqOIDIwMTMvOC82IDE2OjM1LCBYaXNoaSBRaXUg5YaZ6YGTOgo+IENvZGUgY2FuIG5vdCBydW4g aGVyZSBmb3JldmVyLCBzbyByZW1vdmUgdGhlIHVubmVjZXNzYXJ5IHJldHVybi4KPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBYaXNoaSBRaXUgPHFpdXhpc2hpQGh1YXdlaS5jb20+Cj4gU3VnZ2VzdGVkLWJ5 OiBaaGFuZyBZYW5mZWkgPHpoYW5neWFuZmVpQGNuLmZ1aml0c3UuY29tPgoKUmV2aWV3ZWQtYnk6 IFpoYW5nIFlhbmZlaSA8emhhbmd5YW5mZWlAY24uZnVqaXRzdS5jb20+Cgo+IC0tLQo+ICBrZXJu ZWwva2V4ZWMuYyB8ICAgIDUgKy0tLS0KPiAgMSBmaWxlcyBjaGFuZ2VkLCAxIGluc2VydGlvbnMo KyksIDQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2tlcm5lbC9rZXhlYy5jIGIva2Vy bmVsL2tleGVjLmMKPiBpbmRleCA1OWY3YjU1Li4yYTc0ZjMwIDEwMDY0NAo+IC0tLSBhL2tlcm5l bC9rZXhlYy5jCj4gKysrIGIva2VybmVsL2tleGVjLmMKPiBAQCAtMTQ3NCwxMSArMTQ3NCw4IEBA IHN0YXRpYyBpbnQgX19pbml0IF9fcGFyc2VfY3Jhc2hrZXJuZWwoY2hhciAqY21kbGluZSwKPiAg CWlmIChmaXJzdF9jb2xvbiAmJiAoIWZpcnN0X3NwYWNlIHx8IGZpcnN0X2NvbG9uIDwgZmlyc3Rf c3BhY2UpKQo+ICAJCXJldHVybiBwYXJzZV9jcmFzaGtlcm5lbF9tZW0oY2tfY21kbGluZSwgc3lz dGVtX3JhbSwKPiAgCQkJCWNyYXNoX3NpemUsIGNyYXNoX2Jhc2UpOwo+IC0JZWxzZQo+IC0JCXJl dHVybiBwYXJzZV9jcmFzaGtlcm5lbF9zaW1wbGUoY2tfY21kbGluZSwgY3Jhc2hfc2l6ZSwKPiAt CQkJCWNyYXNoX2Jhc2UpOwo+ICAKPiAtCXJldHVybiAwOwo+ICsJcmV0dXJuIHBhcnNlX2NyYXNo a2VybmVsX3NpbXBsZShja19jbWRsaW5lLCBjcmFzaF9zaXplLCBjcmFzaF9iYXNlKTsKPiAgfQo+ ICAKPiAgLyoKPiAKCgotLSAKVGhhbmtzLgpaaGFuZyBZYW5mZWkKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmtleGVjIG1haWxpbmcgbGlzdAprZXhlY0Bs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8va2V4ZWMK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755244Ab3HFIoT (ORCPT ); Tue, 6 Aug 2013 04:44:19 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:12338 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754958Ab3HFIoQ convert rfc822-to-8bit (ORCPT ); Tue, 6 Aug 2013 04:44:16 -0400 X-IronPort-AV: E=Sophos;i="4.89,825,1367942400"; d="scan'208";a="8131974" Message-ID: <5200B75F.6050906@cn.fujitsu.com> Date: Tue, 06 Aug 2013 16:44:15 +0800 From: Zhang Yanfei User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Xishi Qiu CC: ebiederm@xmission.com, kexec@lists.infradead.org, LKML Subject: Re: [PATCH V2] kexec: remove unnecessary return References: <5200B534.7000202@huawei.com> In-Reply-To: <5200B534.7000202@huawei.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/08/06 16:42:53, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/08/06 16:42:54 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2013/8/6 16:35, Xishi Qiu 写道: > Code can not run here forever, so remove the unnecessary return. > > Signed-off-by: Xishi Qiu > Suggested-by: Zhang Yanfei Reviewed-by: Zhang Yanfei > --- > kernel/kexec.c | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/kernel/kexec.c b/kernel/kexec.c > index 59f7b55..2a74f30 100644 > --- a/kernel/kexec.c > +++ b/kernel/kexec.c > @@ -1474,11 +1474,8 @@ static int __init __parse_crashkernel(char *cmdline, > if (first_colon && (!first_space || first_colon < first_space)) > return parse_crashkernel_mem(ck_cmdline, system_ram, > crash_size, crash_base); > - else > - return parse_crashkernel_simple(ck_cmdline, crash_size, > - crash_base); > > - return 0; > + return parse_crashkernel_simple(ck_cmdline, crash_size, crash_base); > } > > /* > -- Thanks. Zhang Yanfei