From: Felix Fietkau <nbd@openwrt.org>
To: Sujith Manoharan <sujith@msujith.org>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH 11/12] ath9k: improve tx scheduling fairness
Date: Tue, 06 Aug 2013 11:53:43 +0200 [thread overview]
Message-ID: <5200C7A7.2000303@openwrt.org> (raw)
In-Reply-To: <20992.47215.657712.108336@gargle.gargle.HOWL>
On 2013-08-06 10:48 AM, Sujith Manoharan wrote:
> Felix Fietkau wrote:
>> Instead of trying to schedule the same TID multiple times in a loop,
>> iterate over other TIDs/stations first.
>
> The txq->axq_ampdu_depth >= ATH_AGGR_MIN_QDEPTH check in the beginning
> of txq_schedule() is not really correct after this, no ?
Right, I'll take care of that.
Thanks for the detailed review.
- Felix
next prev parent reply other threads:[~2013-08-06 9:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 19:56 [PATCH 01/12] ath9k: add utility functions for accessing tid queues Felix Fietkau
2013-08-05 19:56 ` [PATCH 02/12] ath9k: split tid retry packets into a separate queue Felix Fietkau
2013-08-05 19:56 ` [PATCH 03/12] ath9k: add function for getting the tx tid for a packet Felix Fietkau
2013-08-05 19:56 ` [PATCH 04/12] ath9k: add CAB queue info to debugfs Felix Fietkau
2013-08-05 19:56 ` [PATCH 05/12] ath9k: simplify ath_tx_form_aggr Felix Fietkau
2013-08-05 19:56 ` [PATCH 06/12] ath9k: fix block ack window tracking check Felix Fietkau
2013-08-05 19:56 ` [PATCH 07/12] ath9k: prepare queueing code for handling unaggregated traffic Felix Fietkau
2013-08-06 7:45 ` Sujith Manoharan
2013-08-06 9:47 ` Felix Fietkau
2013-08-06 16:32 ` Sujith Manoharan
2013-08-05 19:56 ` [PATCH 08/12] ath9k: fix clearing expired A-MPDU subframes in tx completion Felix Fietkau
2013-08-05 19:56 ` [PATCH 09/12] ath9k: always clear ps filter bit on new assoc Felix Fietkau
2013-08-06 7:55 ` Sujith Manoharan
2013-08-06 9:49 ` Felix Fietkau
2013-08-05 19:56 ` [PATCH 10/12] ath9k: use software queues for un-aggregated data packets Felix Fietkau
2013-08-06 8:44 ` Sujith Manoharan
2013-08-06 9:38 ` Felix Fietkau
2013-08-05 19:56 ` [PATCH 11/12] ath9k: improve tx scheduling fairness Felix Fietkau
2013-08-06 8:48 ` Sujith Manoharan
2013-08-06 9:53 ` Felix Fietkau [this message]
2013-08-05 19:56 ` [PATCH 12/12] ath9k: use software queueing for multicast traffic Felix Fietkau
2013-08-06 7:21 ` [PATCH 01/12] ath9k: add utility functions for accessing tid queues Sujith Manoharan
2013-08-06 9:40 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5200C7A7.2000303@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sujith@msujith.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.