From: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [iptables-nftables PATCH 2/3] nft: Generalize nft_rule_list() against current family
Date: Wed, 07 Aug 2013 12:02:25 +0300 [thread overview]
Message-ID: <52020D21.3080504@linux.intel.com> (raw)
In-Reply-To: <20130807090054.GB6935@localhost>
Hi Pablo,
>> +const char *nft_parse_target(struct nft_rule *r, const void **targinfo,
>> >+ size_t *target_len)
>> >+{
>> >+ struct nft_rule_expr_iter *iter;
>> >+ struct nft_rule_expr *expr;
>> >+ const char *targname;
> Need targname = NULL, otherwise:
>
> nft-shared.c: In function ‘nft_parse_target’:
> nft-shared.c:289:14: warning: ‘targname’ may be used uninitialized in
> this function [-Wmaybe-uninitialized
Missed this warning, thanks for finding it.
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-08-07 9:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 8:31 [iptables-nftables PATCH 0/3] Generalize nft_rule_list() (+ 2 fixes) Tomasz Bursztyka
2013-08-07 8:31 ` [iptables-nftables PATCH 1/3] nft: Remove useless test on rulenum in nft_rule_list() Tomasz Bursztyka
2013-08-07 8:59 ` Pablo Neira Ayuso
2013-08-07 8:31 ` [iptables-nftables PATCH 2/3] nft: Generalize nft_rule_list() against current family Tomasz Bursztyka
2013-08-07 9:00 ` Pablo Neira Ayuso
2013-08-07 9:02 ` Tomasz Bursztyka [this message]
2013-08-07 8:31 ` [iptables-nftables PATCH 3/3] nft: Print unknown target data only when relevant Tomasz Bursztyka
2013-08-07 9:01 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52020D21.3080504@linux.intel.com \
--to=tomasz.bursztyka@linux.intel.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.