From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonyoung Shim Subject: Re: [PATCH 1/3] drm: use common drm_gem_dmabuf_release in i915/exynos drivers Date: Wed, 07 Aug 2013 19:18:45 +0900 Message-ID: <52021F05.6070401@samsung.com> References: <1375866908-5000-1-git-send-email-daniel.vetter@ffwll.ch> <1375866908-5000-2-git-send-email-daniel.vetter@ffwll.ch> <014c01ce9352$1e559690$5b00c3b0$%dae@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Inki Dae Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: dri-devel@lists.freedesktop.org On 08/07/2013 06:55 PM, Daniel Vetter wrote: > On Wed, Aug 7, 2013 at 11:40 AM, Inki Dae wrote: >>> -----Original Message----- >>> From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch] >>> Sent: Wednesday, August 07, 2013 6:15 PM >>> To: DRI Development >>> Cc: Intel Graphics Development; Daniel Vetter; Inki Dae >>> Subject: [PATCH 1/3] drm: use common drm_gem_dmabuf_release in i915/exynos >>> drivers >>> >>> Note that this is slightly tricky since both drivers store their >>> native objects in dma_buf->priv. But both also embed the base >>> drm_gem_object at the first position, so the implicit cast is ok. >>> >>> To use the release helper we need to export it, too. >> Yeah, may I repost this patch with additional work? We also need to export >> with a gem object instead of specific one like you did. I think dmabuf stuff of exynos can be replaced to common drm_gem_dmabuf. Already dmabuf stuff of drm_gem_cma_helper.c was substituted to common drm_gem_dmabuf with low-level hook functions to use prime helpers. Thanks. > I'm confused here what you mean, so pls just submit the patch. That > usually helps ;-) > -Daniel