From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] xen: cleanup unused request{_dt,
	}_irq() parameter
Date: Wed, 7 Aug 2013 12:59:43 +0100
Message-ID: <520236AF.7090500@citrix.com>
References: <1375810929-19254-1-git-send-email-andrew.cooper3@citrix.com>
	<5202166902000078000E9D13@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1V72Ud-0001IV-MR
	for xen-devel@lists.xenproject.org; Wed, 07 Aug 2013 12:05:31 +0000
In-Reply-To: <5202166902000078000E9D13@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>, Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 07/08/13 08:42, Jan Beulich wrote:
>>>> On 06.08.13 at 19:42, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>> The irqflags parameter appears to be an unused vestigial parameter right from
>> the integration of the IOMMU code in 2007.  The parameter is 0 at all
>> callsites and never used.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Reviewed-by: Jan Beulich <JBeulich@suse.com>
>
> If I were to commit it - with the appropriate acks - I'd also cleanup
> the white space damage left in place:
>
>> --- a/xen/arch/x86/irq.c
>> +++ b/xen/arch/x86/irq.c
>> @@ -951,7 +951,7 @@ __initcall(irq_ratelimit_init);
>>  
>>  int __init request_irq(unsigned int irq,
>>          void (*handler)(int, void *, struct cpu_user_regs *),
>> -        unsigned long irqflags, const char * devname, void *dev_id)
>> +        const char * devname, void *dev_id)
> Here ...
>
>> --- a/xen/include/xen/irq.h
>> +++ b/xen/include/xen/irq.h
>> @@ -93,7 +93,7 @@ extern int setup_irq(unsigned int irq, struct irqaction *);
>>  extern void release_irq(unsigned int irq);
>>  extern int request_irq(unsigned int irq,
>>                 void (*handler)(int, void *, struct cpu_user_regs *),
>> -               unsigned long irqflags, const char * devname, void *dev_id);
>> +               const char * devname, void *dev_id);
> ... and here.
>
> I'd encourage you to in the future do such obvious cleanup on
> code you touch anyway.
>
> Jan
>

Certainly (I tend to, but it slipped my mind this time) - I shall submit v2

~Andrew