All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: dev@dpdk.org, "Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [PATCH] dpdk: remove typos using codespell utility
Date: Wed, 14 Jun 2017 23:54:29 +0200	[thread overview]
Message-ID: <5202656.sPjQrbsmro@xps> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE23ECEB4CD@IRSMSX104.ger.corp.intel.com>

> > Fixing typos across dpdk source code using codespell utility.
> > Skipped the ethdev driver's base code fixes to keep the base
> > code intact.
> > 
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> 
> Good work. More people should run spell checks on their code. It is an easy fix
> that improves the overall quality.
> 
> Note the uses of "iff", which are corrected to "if", are probable correct in
> the sense of "iff = if and only if": https://en.wikipedia.org/wiki/If_and_only_if 
> However, unless mathematical logicians turn up to object it is fine to change it. :-)
> 
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks

You are welcome to add codespell to the distributed CI if there
is a way to automate it without too much false positives.

      reply	other threads:[~2017-06-14 21:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07  5:05 [PATCH] dpdk: remove typos using codespell utility Jerin Jacob
2017-06-07  9:20 ` Mcnamara, John
2017-06-14 21:54   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5202656.sPjQrbsmro@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=john.mcnamara@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.