All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nguyen Viet Dung <nv-dung-HEF513clHfp3+QwDJ9on6Q@public.gmane.org>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH v2 1/1 resend] i2c: rcar: modify I2C driver
Date: Thu, 08 Aug 2013 10:13:16 +0900	[thread overview]
Message-ID: <5202F0AC.4070609@jinso.co.jp> (raw)
In-Reply-To: <20130807151234.GH2978@katana>

Difference between H2 and H1 in hardware is only CDF bit of ICCCR register.
So, by using the flag variable in pdata, it is possible to distinguish 
H2 and H1.

If this method is not a common method, please tell me about common method.

Thanks,
Dung
On 08/08/2013 12:12 AM, Wolfram Sang wrote:
> On Mon, Aug 05, 2013 at 04:19:34PM +0900, Nguyen Viet Dung wrote:
>> This patch modify I2C driver of rcar-H1 to usable on both rcar-H1 and rcar-H2.
>>
>> Signed-off-by: Nguyen Viet Dung <nv-dung-HEF513clHfp3+QwDJ9on6Q@public.gmane.org>
> Isn't it possible to distinguish between H1 and H2 somewhere in
> hardware? Then we could skip the 'flags' variable in pdata.
>
> Thanks,
>
>     Wolfram

  reply	other threads:[~2013-08-08  1:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-05  7:19 [PATCH v2 0/1 resend] ARM: shmobile: r8a7790: add I2C support Nguyen Viet Dung
     [not found] ` <1375687174-577-1-git-send-email-nv-dung-HEF513clHfp3+QwDJ9on6Q@public.gmane.org>
2013-08-05  7:19   ` [PATCH v2 1/1 resend] i2c: rcar: modify I2C driver Nguyen Viet Dung
     [not found]     ` <1375687174-577-2-git-send-email-nv-dung-HEF513clHfp3+QwDJ9on6Q@public.gmane.org>
2013-08-07 15:12       ` Wolfram Sang
2013-08-07 15:12         ` Wolfram Sang
2013-08-08  1:13         ` Nguyen Viet Dung [this message]
     [not found]           ` <5202F0AC.4070609-HEF513clHfp3+QwDJ9on6Q@public.gmane.org>
2013-08-08  8:12             ` Wolfram Sang
2013-08-08  8:12               ` Wolfram Sang
     [not found]               ` <20130808080819.GA6070-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2013-08-08 11:39                 ` Nguyen Viet Dung
2013-08-08 11:39                   ` Nguyen Viet Dung
  -- strict thread matches above, loose matches on Subject: below --
2013-07-26 10:33 [PATCH v2 0/1 resend] ARM: shmobile: r8a7790: add I2C support Nguyen Viet Dung
     [not found] ` <1374834819-319-1-git-send-email-nv-dung-HEF513clHfp3+QwDJ9on6Q@public.gmane.org>
2013-07-26 10:33   ` [PATCH v2 1/1 resend] i2c: rcar: modify I2C driver Nguyen Viet Dung
2013-07-26 10:33     ` Nguyen Viet Dung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5202F0AC.4070609@jinso.co.jp \
    --to=nv-dung-hef513clhfp3+qwdj9on6q@public.gmane.org \
    --cc=kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.