From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [PATCH 1/2] pinctrl: pinconf_generic: add utility functions for add map/configs Date: Thu, 8 Aug 2013 12:53:15 +0530 Message-ID: <52034763.9060307@nvidia.com> References: <1374833754-19659-1-git-send-email-ldewangan@nvidia.com> <1374833754-19659-2-git-send-email-ldewangan@nvidia.com> <51F2B384.9050706@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: Stephen Warren , Grant Likely , Rob Herring , Rob Landley , Samuel Ortiz , Lee Jones , "devicetree-discuss@lists.ozlabs.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Graeme Gregory , "kishon@ti.com" , Stephen Warren , "devicetree@vger.kernel.org" List-Id: devicetree@vger.kernel.org On Wednesday 07 August 2013 11:57 PM, Linus Walleij wrote: > On Fri, Jul 26, 2013 at 7:36 PM, Stephen Warren wrote: >> On 07/26/2013 04:15 AM, Laxman Dewangan wrote: >>> Some of pincontrol driver needs the utility function to create map >>> list. The utility function needed for adding mux, configs etc. > It is a noble goal to unify this and thank you *very* much for taking > it on. Thanks Linus, There is 3 patches of version 3 of same series, if it gets concluded/applied then I will have some more patches for removing duplicate code from individual driver. >> >> I don't think those are the correct files for this code. Presumably >> there's no reason at all why a pinctrl driver that doesn't require >> CONFIG_GENERIC_PINCONF can't use these basic utility functions. Perhaps >> add a new pinctrl-utils file? > Agree with Stephen, we need to put this in a separate file, such at > pinctrl-dt.c or just put it into core.c. > Version 3 address all these. Thanks,, Laxman