All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <dborkman@redhat.com>
To: Jesper Dangaard Brouer <jbrouer@redhat.com>
Cc: Ryan O'Hara <rohara@redhat.com>,
	Simon Horman <horms@verge.net.au>,
	lvs-devel@vger.kernel.org, Wensong Zhang <wensong@linux-vs.org>,
	Julian Anastasov <ja@ssi.bg>, Thomas Graf <tgraf@redhat.com>
Subject: Re: ipvsadm git head not compiling on RHEL6
Date: Thu, 08 Aug 2013 11:23:12 +0200	[thread overview]
Message-ID: <52036380.9020806@redhat.com> (raw)
In-Reply-To: <20130808111722.6f092b89@redhat.com>

On 08/08/2013 11:17 AM, Jesper Dangaard Brouer wrote:
> On Thu, 08 Aug 2013 10:27:05 +0200
> Daniel Borkmann <dborkman@redhat.com> wrote:
>> On 08/08/2013 10:19 AM, Jesper Dangaard Brouer wrote:
>>>
>>> I noticed that I get an compile error, when compiling ipvsadm
>>> git HEAD 1ea1f41f4 on RHEL6.4.
>>>
>>> Compile Error:
>>>
>>> gcc -Wall -Wunused -Wstrict-prototypes -g -o ipvsadm ipvsadm.o config_stream.o dynamic_array.o libipvs/libipvs.a -lpopt -lnl
>>> libipvs/libipvs.a(libipvs.o): In function `ipvs_nl_send_message':
>>> /home/jbrouer/git/ipvsadm/libipvs/libipvs.c:76: undefined reference to `nl_socket_alloc'
>>> /home/jbrouer/git/ipvsadm/libipvs/libipvs.c:91: undefined reference to `nl_socket_free'
>>> /home/jbrouer/git/ipvsadm/libipvs/libipvs.c:107: undefined reference to `nl_socket_free'
>>> /home/jbrouer/git/ipvsadm/libipvs/libipvs.c:112: undefined reference to `nl_socket_free'
>>> collect2: ld returned 1 exit status
>>> make: *** [ipvsadm] Error 1
>>>
>>> I'll investigate, but hints would be appreciated ;-)
>>
>> Did you try using libnl3? (Migrating to libnl3 would be better anyway as
>> distributions try to get rid of supporting libnl.)
>
> Nope, I'm using the default libnl coming with RHEL6.4.
>
> Its not really an option to import/change to libnl3 for RHEL6. But you
> could try poking Thomas Graf ;-)
>
>> I think sometime in libnl*, nl_handle_{alloc,free} was changed to
>> nl_socket_{alloc,free}.
>
> Yes, I can see that your libnl3 commit f48e93c1 (libipvs: libnl3: fix
> compilation error) caused this issue.

Well, because it broke the build when using libnl3 which should be the
way to go for most users. ;-)

You could add a fall-back define for libnl1 users, so that there's just
a textual replacement to the old name.

>> Maybe try changing include locations and libs that are linked against
>> to libnl3.
>
> We officially support ipvsadm for RHEL6, so its not an option to link
> against libnl3, as we need to supply an official package... else we/I
> would need to have an adaption patch in the RPM (I were looking to
> rebase RHEL6 to use the upcoming ipvsadm release).

  reply	other threads:[~2013-08-08  9:23 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-08  4:59 [PATCH] Allow override of CFLAGS Simon Horman
2013-08-08  6:13 ` Julian Anastasov
2013-08-08  7:34   ` Simon Horman
2013-08-08  8:30     ` Julian Anastasov
2013-08-08  7:47 ` Daniel Borkmann
2013-08-08  8:19   ` ipvsadm git head not compiling on RHEL6 Jesper Dangaard Brouer
2013-08-08  8:27     ` Daniel Borkmann
2013-08-08  9:00       ` Simon Horman
2013-08-08  9:17       ` Jesper Dangaard Brouer
2013-08-08  9:23         ` Daniel Borkmann [this message]
2013-08-08  9:33           ` Thomas Graf
2013-08-08  9:00   ` [PATCH] Allow override of CFLAGS Simon Horman
2013-08-08  9:05     ` Daniel Borkmann
2013-08-08 12:10   ` [PATCH] ipvsadm: fix compiling tool on distros with only libnl-1 Jesper Dangaard Brouer
2013-08-08 12:23     ` Daniel Borkmann
2013-08-08 20:00     ` Ryan O'Hara
2013-08-09  5:47       ` Simon Horman
2013-08-09  6:27         ` [PATCH v2] " Jesper Dangaard Brouer
2013-08-09  8:32           ` Simon Horman
2013-08-09  6:43         ` [PATCH] " Jesper Dangaard Brouer
2013-08-09  6:55           ` Daniel Borkmann
2013-08-09  8:31             ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52036380.9020806@redhat.com \
    --to=dborkman@redhat.com \
    --cc=horms@verge.net.au \
    --cc=ja@ssi.bg \
    --cc=jbrouer@redhat.com \
    --cc=lvs-devel@vger.kernel.org \
    --cc=rohara@redhat.com \
    --cc=tgraf@redhat.com \
    --cc=wensong@linux-vs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.