github pull requests, comments and rebase

[Loic Dachary <loic@dachary.org>]

[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]

Hi Sage,

During the discussions about continuous integration at the CDS this week ( http://youtu.be/cGosx5zD4FM?t=1h16m05s ) you mentionned that github was able to keep track of the successive versions of a pull request commit, even in the case of a rebase. I just tried the following:

a) comment on commit associated to https://github.com/ceph/ceph/pull/455 ( both inline and at the end of the commit )
b) Christophe rebased the associated commit against master and git push --force to publish it
c) The original commit  does not show up in https://github.com/ceph/ceph/pull/455  and the new commit, result of the rebase, https://github.com/kri5/ceph/commit/051b0c3e15c98714b95fca5cb7838de9614dc8e3 does not display my inline comments.

Do you to know a different workflow that would allow rebase and keep track of the different versions / comments of the pull request ? Something similar to what you have in gerrit with https://review.openstack.org/#/c/22708/ for example where you can see and compare the patch sets.

Cheers

-- 
Loïc Dachary, Artisan Logiciel Libre
All that is necessary for the triumph of evil is that good people do nothing.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]