Re: [PATCH v2 2/9] ARM: shmobile: r8a7790: Constify platform data and resources

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 08-08-2013 2:56, Laurent Pinchart wrote:

> Platform data and resources for core devices are kmemdup()ed when the
> corresponding devices are registered and can thus be declared as const.
> Do so.

> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>   arch/arm/mach-shmobile/setup-r8a7790.c | 21 +++++++++++----------
>   1 file changed, 11 insertions(+), 10 deletions(-)

> diff --git a/arch/arm/mach-shmobile/setup-r8a7790.c b/arch/arm/mach-shmobile/setup-r8a7790.c
> index d0f5c9f..988266e 100644
> --- a/arch/arm/mach-shmobile/setup-r8a7790.c
> +++ b/arch/arm/mach-shmobile/setup-r8a7790.c
> @@ -31,17 +31,18 @@
>   #include <mach/r8a7790.h>
>   #include <asm/mach/arch.h>
>
> -static struct resource pfc_resources[] __initdata = {
> +static const struct resource pfc_resources[] __initdata = {

    I think *const* data should be annotated with '__initconst', no?

WBR, Sergei