diff for duplicates of <52037F9A.7070802@roeck-us.net> diff --git a/a/1.txt b/N1/1.txt index 8deec51..5bfaa15 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -5,7 +5,7 @@ On 08/08/2013 02:47 AM, Wei Ni wrote: >>> Adding the power control support to power on/off the vdd rail. >>> And make sure that power is enabled before accessing the device. >>> ->>> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> +>>> Signed-off-by: Wei Ni <wni@nvidia.com> >>> --- >>> drivers/hwmon/lm90.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 49 insertions(+) @@ -108,7 +108,7 @@ directly in those functions. Again no need for the additional function. >> If the regulator subsystem is not configured, you especially don't need or want >> to pollute the log with an error message. >> ->>> + if (PTR_ERR(data->lm90_reg) == -ENODEV) +>>> + if (PTR_ERR(data->lm90_reg) = -ENODEV) >>> + dev_info(&client->dev, >>> + "No regulator found for vdd. Assuming vdd is always powered."); >>> + else @@ -132,7 +132,7 @@ directly in those functions. Again no need for the additional function. Handle the error in the if case. -> if (PTR_ERR(data->lm90_reg) == -EPROBE_DEFER) +> if (PTR_ERR(data->lm90_reg) = -EPROBE_DEFER) > return -EPRPBE_DEFER; > > data->lm90_reg = !!IS_ERR(data->lm90_reg); @@ -159,7 +159,7 @@ Matter of opinion if you want to check for IS_ERR or NULL later on. >>> + >>> /* Set the device type */ >>> data->kind = id->driver_data; ->>> if (data->kind == adm1032) { +>>> if (data->kind = adm1032) { >>> @@ -1473,6 +1515,10 @@ exit_remove_files: >>> lm90_remove_files(client, data); >>> exit_restore: @@ -186,3 +186,9 @@ Matter of opinion if you want to check for IS_ERR or NULL later on. > > > + + +_______________________________________________ +lm-sensors mailing list +lm-sensors@lm-sensors.org +http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index 518cee7..6297b16 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,9 +3,9 @@ "ref\0520359E9.1000600@roeck-us.net\0" "ref\052036920.4050808@nvidia.com\0" "ref\052036920.4050808-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org\0" - "From\0Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>\0" - "Subject\0Re: [PATCH v2 1/3] hwmon: (lm90) Add power control\0" - "Date\0Thu, 08 Aug 2013 04:23:06 -0700\0" + "From\0Guenter Roeck <linux@roeck-us.net>\0" + "Subject\0Re: [lm-sensors] [PATCH v2 1/3] hwmon: (lm90) Add power control\0" + "Date\0Thu, 08 Aug 2013 11:23:06 +0000\0" "To\0Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\0" "Cc\0khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>" swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> @@ -23,7 +23,7 @@ ">>> Adding the power control support to power on/off the vdd rail.\n" ">>> And make sure that power is enabled before accessing the device.\n" ">>>\n" - ">>> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\n" + ">>> Signed-off-by: Wei Ni <wni@nvidia.com>\n" ">>> ---\n" ">>> drivers/hwmon/lm90.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++\n" ">>> 1 file changed, 49 insertions(+)\n" @@ -126,7 +126,7 @@ ">> If the regulator subsystem is not configured, you especially don't need or want\n" ">> to pollute the log with an error message.\n" ">>\n" - ">>> +\t\tif (PTR_ERR(data->lm90_reg) == -ENODEV)\n" + ">>> +\t\tif (PTR_ERR(data->lm90_reg) = -ENODEV)\n" ">>> +\t\t\tdev_info(&client->dev,\n" ">>> +\t\t\t\t \"No regulator found for vdd. Assuming vdd is always powered.\");\n" ">>> +\t\telse\n" @@ -150,7 +150,7 @@ "\n" "Handle the error in the if case.\n" "\n" - "> if (PTR_ERR(data->lm90_reg) == -EPROBE_DEFER)\n" + "> if (PTR_ERR(data->lm90_reg) = -EPROBE_DEFER)\n" "> return -EPRPBE_DEFER;\n" ">\n" "> data->lm90_reg = !!IS_ERR(data->lm90_reg);\n" @@ -177,7 +177,7 @@ ">>> +\n" ">>> \t/* Set the device type */\n" ">>> \tdata->kind = id->driver_data;\n" - ">>> \tif (data->kind == adm1032) {\n" + ">>> \tif (data->kind = adm1032) {\n" ">>> @@ -1473,6 +1515,10 @@ exit_remove_files:\n" ">>> \tlm90_remove_files(client, data);\n" ">>> exit_restore:\n" @@ -203,6 +203,12 @@ ">>\n" ">\n" ">\n" - > + ">\n" + "\n" + "\n" + "_______________________________________________\n" + "lm-sensors mailing list\n" + "lm-sensors@lm-sensors.org\n" + http://lists.lm-sensors.org/mailman/listinfo/lm-sensors -eba3c759f23399b5136e4b16fd8d6a4fe87f87294c62ad4fa956480f0387d1ef +f87b825853bc4fcf03dc638248fb733753c5807c3cb3fbc49b17e0779999aa9d
diff --git a/a/1.txt b/N2/1.txt index 8deec51..2e52124 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -5,7 +5,7 @@ On 08/08/2013 02:47 AM, Wei Ni wrote: >>> Adding the power control support to power on/off the vdd rail. >>> And make sure that power is enabled before accessing the device. >>> ->>> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> +>>> Signed-off-by: Wei Ni <wni@nvidia.com> >>> --- >>> drivers/hwmon/lm90.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 49 insertions(+) diff --git a/a/content_digest b/N2/content_digest index 518cee7..91c6c91 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,18 +2,10 @@ "ref\01375944991-29182-2-git-send-email-wni@nvidia.com\0" "ref\0520359E9.1000600@roeck-us.net\0" "ref\052036920.4050808@nvidia.com\0" - "ref\052036920.4050808-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org\0" - "From\0Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>\0" - "Subject\0Re: [PATCH v2 1/3] hwmon: (lm90) Add power control\0" + "From\0linux@roeck-us.net (Guenter Roeck)\0" + "Subject\0[PATCH v2 1/3] hwmon: (lm90) Add power control\0" "Date\0Thu, 08 Aug 2013 04:23:06 -0700\0" - "To\0Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\0" - "Cc\0khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>" - swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> - Matthew Longnecker <MLongnecker-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> - linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org> - lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org <lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org> - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> - " linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On 08/08/2013 02:47 AM, Wei Ni wrote:\n" @@ -23,7 +15,7 @@ ">>> Adding the power control support to power on/off the vdd rail.\n" ">>> And make sure that power is enabled before accessing the device.\n" ">>>\n" - ">>> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\n" + ">>> Signed-off-by: Wei Ni <wni@nvidia.com>\n" ">>> ---\n" ">>> drivers/hwmon/lm90.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++\n" ">>> 1 file changed, 49 insertions(+)\n" @@ -205,4 +197,4 @@ ">\n" > -eba3c759f23399b5136e4b16fd8d6a4fe87f87294c62ad4fa956480f0387d1ef +18c8ceeda0d14409fee0087118c45ed5902aeddbfa421fce302d554bc17f5aed
diff --git a/a/1.txt b/N3/1.txt index 8deec51..2e52124 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -5,7 +5,7 @@ On 08/08/2013 02:47 AM, Wei Ni wrote: >>> Adding the power control support to power on/off the vdd rail. >>> And make sure that power is enabled before accessing the device. >>> ->>> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> +>>> Signed-off-by: Wei Ni <wni@nvidia.com> >>> --- >>> drivers/hwmon/lm90.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 49 insertions(+) diff --git a/a/content_digest b/N3/content_digest index 518cee7..0ce617e 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -2,18 +2,17 @@ "ref\01375944991-29182-2-git-send-email-wni@nvidia.com\0" "ref\0520359E9.1000600@roeck-us.net\0" "ref\052036920.4050808@nvidia.com\0" - "ref\052036920.4050808-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org\0" - "From\0Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>\0" + "From\0Guenter Roeck <linux@roeck-us.net>\0" "Subject\0Re: [PATCH v2 1/3] hwmon: (lm90) Add power control\0" "Date\0Thu, 08 Aug 2013 04:23:06 -0700\0" - "To\0Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\0" - "Cc\0khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>" - swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> - Matthew Longnecker <MLongnecker-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> - linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org> - lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org <lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org> - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> - " linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>\0" + "To\0Wei Ni <wni@nvidia.com>\0" + "Cc\0khali@linux-fr.org <khali@linux-fr.org>" + swarren@wwwdotorg.org <swarren@wwwdotorg.org> + Matthew Longnecker <MLongnecker@nvidia.com> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> + lm-sensors@lm-sensors.org <lm-sensors@lm-sensors.org> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + " linux-tegra@vger.kernel.org <linux-tegra@vger.kernel.org>\0" "\00:1\0" "b\0" "On 08/08/2013 02:47 AM, Wei Ni wrote:\n" @@ -23,7 +22,7 @@ ">>> Adding the power control support to power on/off the vdd rail.\n" ">>> And make sure that power is enabled before accessing the device.\n" ">>>\n" - ">>> Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>\n" + ">>> Signed-off-by: Wei Ni <wni@nvidia.com>\n" ">>> ---\n" ">>> drivers/hwmon/lm90.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++\n" ">>> 1 file changed, 49 insertions(+)\n" @@ -205,4 +204,4 @@ ">\n" > -eba3c759f23399b5136e4b16fd8d6a4fe87f87294c62ad4fa956480f0387d1ef +2d9770503b163745e029ebf4ed64d987e17e3fbc9057df833b8e8b175c14476e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.