From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org,
patches@linaro.org, xen-devel@lists.xen.org
Subject: Re: [PATCH v4 2/2] xen/arm: errata 766422: decode thumb store during data abort
Date: Thu, 08 Aug 2013 13:04:24 +0100 [thread overview]
Message-ID: <52038948.20104@linaro.org> (raw)
In-Reply-To: <1375960179.970.69.camel@kazak.uk.xensource.com>
On 08/08/2013 12:09 PM, Ian Campbell wrote:
> On Tue, 2013-08-06 at 19:31 +0100, Julien Grall wrote:
>> + /*
>> + * Errata 766422: Thumb store translation fault to Hypervisor may
>> + * not have correct HSR Rt value.
>> + */
>> + if ( cpu_has_errata_766422() && (regs->cpsr & PSR_THUMB) && dabt.write )
>> + {
>> + rc = decode_instruction(regs, &info.dabt);
>> + if ( rc )
>> + goto bad_data_abort;
>
> Consider logging here so we know which caller of decode_instruction
> failed?
I will add a printk.
> Either way:
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> Ian.
>
--
Julien Grall
next prev parent reply other threads:[~2013-08-08 12:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 18:31 [PATCH v4 0/2] Implement errata 766422 Julien Grall
2013-08-06 18:31 ` [PATCH v4 1/2] xen/arm: Start to implement an ARM decoder instruction Julien Grall
2013-08-08 11:08 ` Ian Campbell
2013-08-08 11:52 ` Julien Grall
2013-08-08 12:13 ` Julien Grall
2013-08-06 18:31 ` [PATCH v4 2/2] xen/arm: errata 766422: decode thumb store during data abort Julien Grall
2013-08-08 11:09 ` Ian Campbell
2013-08-08 12:04 ` Julien Grall [this message]
2013-08-08 12:12 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52038948.20104@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=patches@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.