From: Julien Grall <julien.grall@linaro.org>
To: Chen Baozi <baozich@gmail.com>
Cc: Xen Developer List <xen-devel@lists.xen.org>,
Ian Campbell <Ian.Campbell@citrix.com>,
Bamvor Jian Zhang <bjzhang@suse.com>
Subject: Re: [PATCH v5 2/5] xen/arm: add 8250 compatible UART support for early_printk
Date: Thu, 08 Aug 2013 13:06:48 +0100 [thread overview]
Message-ID: <520389D8.2080101@linaro.org> (raw)
In-Reply-To: <6282899A-78C3-4132-8DD7-EA3C1A925E57@gmail.com>
On 08/08/2013 01:04 PM, Chen Baozi wrote:
>
> On Aug 8, 2013, at 7:36 PM, Ian Campbell <Ian.Campbell@citrix.com> wrote:
>
>> On Thu, 2013-08-08 at 12:34 +0100, Ian Campbell wrote:
>>
>>>> diff --git a/xen/include/xen/8250-uart.h b/xen/include/xen/8250-uart.h
>>>> index 7287364..33daa6d 100644
>>>> --- a/xen/include/xen/8250-uart.h
>>>> +++ b/xen/include/xen/8250-uart.h
>>>> @@ -22,6 +22,10 @@
>>>> #ifndef __XEN_8250_UART_H__
>>>> #define __XEN_8250_UART_H__
>>>>
>>>> +#ifdef CONFIG_ARM
>>>> +#define REG_SHIFT 2
>>>> +#endif
>>>
>>> I think this should actually be part of the per-platform early-printk
>>> block, e.g. EARLY_UART_REG_SHIFT
>>
>> I should have also said that for non-early drivers this should come from
>> the device tree.
>>
>> Possibly in the case of your OMAP speciifc driver it could be hardcoded,
>> but only if it isn't in DT IMHO.
>
> It seems OMAP5's DT doesn't have this info? Does exynos5 have it?
Exynos5 uses a different UART which doesn't need shift.
--
Julien Grall
next prev parent reply other threads:[~2013-08-08 12:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 10:52 [PATCH v5 0/5] Add UART support and arch timer initialization for OMAP5 Chen Baozi
2013-08-08 10:52 ` [PATCH v5 1/5] xen: rename ns16550-uart.h to 8250-uart.h and fix some typos Chen Baozi
2013-08-08 10:52 ` [PATCH v5 2/5] xen/arm: add 8250 compatible UART support for early_printk Chen Baozi
2013-08-08 11:34 ` Ian Campbell
2013-08-08 11:36 ` Ian Campbell
2013-08-08 12:04 ` Chen Baozi
2013-08-08 12:06 ` Julien Grall [this message]
2013-08-08 12:17 ` Chen Baozi
2013-08-08 12:32 ` Chen Baozi
2013-08-08 12:54 ` Ian Campbell
2013-08-08 10:52 ` [PATCH v5 3/5] xen/arm: Add the new OMAP UART driver Chen Baozi
2013-08-08 11:41 ` Ian Campbell
2013-08-08 11:58 ` Chen Baozi
2013-08-08 12:03 ` Ian Campbell
2013-08-08 10:52 ` [PATCH v5 4/5] xen/arm: Add support for device tree specified arch_timer clock frequency Chen Baozi
2013-08-08 12:18 ` Ian Campbell
2013-08-08 12:41 ` Julien Grall
2013-08-08 12:45 ` Ian Campbell
2013-08-08 10:52 ` [PATCH v5 5/5] xen/arm: Platform recognition and initialize arch_timer for the OMAP5 Chen Baozi
2013-08-08 12:18 ` Ian Campbell
2013-08-08 12:23 ` Chen Baozi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520389D8.2080101@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=baozich@gmail.com \
--cc=bjzhang@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.