All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Tinguely <tinguely@sgi.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfsprogs/io: add readdir command
Date: Thu, 08 Aug 2013 09:05:43 -0500	[thread overview]
Message-ID: <5203A5B7.4020102@sgi.com> (raw)
In-Reply-To: <1374669868-14075-1-git-send-email-bfoster@redhat.com>

On 07/24/13 07:44, Brian Foster wrote:
> readdir reads the directory entries from an open directory from
> the provided offset (or 0 if not specified). On completion,
> readdir prints summary information regarding the number of
> operations and bytes transferred. Options are available to specify
> the starting offset, length and verbose mode to dump directory
> entry information.
>
> Signed-off-by: Brian Foster<bfoster@redhat.com>
> ---
>
> v2:
> - Convert from getdents to readdir.
> - Use configure mechanism for libc readdir() availability (zab).
> - Add extra dirent fields to verbose output (zab).
>

Just started to look at this.

Shouldn't there be a "closedir(dir);" to close the directory stream and 
release the directory structure?

Could we get a little info for the xfs_io man page?

Looks like a nice feature.

Thanks.

--Mark.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-08-08 14:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-24 12:44 [PATCH v2] xfsprogs/io: add readdir command Brian Foster
2013-08-08 14:05 ` Mark Tinguely [this message]
2013-08-08 17:38   ` Brian Foster
2013-08-08 18:36     ` Mark Tinguely
2013-08-08 20:39   ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5203A5B7.4020102@sgi.com \
    --to=tinguely@sgi.com \
    --cc=bfoster@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.