All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Anthony Liguori" <aliguori@us.ibm.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 2/2] Revert "memory: Return -1 again on reads from unsigned regions"
Date: Thu, 08 Aug 2013 17:27:58 +0200	[thread overview]
Message-ID: <5203B8FE.5070200@web.de> (raw)
In-Reply-To: <CAFEAcA8wfnXaZkHh_qpJbm5SzfNgthNdWS_g8N5VSHWp_0RW4A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 741 bytes --]

On 2013-08-08 17:23, Peter Maydell wrote:
> On 3 August 2013 09:31, Jan Kiszka <jan.kiszka@web.de> wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> This reverts commit 9b8c69243585a32d14b9bb9fcd52c37b0b5a1b71.
>>
>> The commit was wrong: We only return -1 on invalid accesses, not on
>> valid but unbacked ones. This broke various corner cases.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> 
> This revert fixes the regression in the 'musicpal' board.
> 
> Presumably these two patches should go into 1.6 since it is
> a regression fix... cc'ing Anthony.
> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

Yes, for 1.6 definitely. Sorry, forgot the proper CCing/tagging.

Thanks,
Jan



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

  reply	other threads:[~2013-08-08 15:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <51FCBF4E.90605@web.de>
2013-08-03  8:31 ` [Qemu-devel] [PATCH 2/2] Revert "memory: Return -1 again on reads from unsigned regions" Jan Kiszka
2013-08-08 15:23   ` Peter Maydell
2013-08-08 15:27     ` Jan Kiszka [this message]
2013-08-08 16:46     ` Andreas Färber
2013-08-08 16:48       ` Peter Maydell
2013-08-08 16:55         ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5203B8FE.5070200@web.de \
    --to=jan.kiszka@web.de \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.