From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7SBv-0004pH-Vd for qemu-devel@nongnu.org; Thu, 08 Aug 2013 11:32:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V7SBq-0007M3-3m for qemu-devel@nongnu.org; Thu, 08 Aug 2013 11:31:55 -0400 Received: from david.siemens.de ([192.35.17.14]:18668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7SBp-0007Lj-Jz for qemu-devel@nongnu.org; Thu, 08 Aug 2013 11:31:49 -0400 Message-ID: <5203B9E2.8080808@siemens.com> Date: Thu, 08 Aug 2013 17:31:46 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <51E5405C.6080108@siemens.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] memory: Return -1 again on reads from unsigned regions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , qemu-devel On 2013-08-08 17:13, Peter Maydell wrote: > On 16 July 2013 13:45, Jan Kiszka wrote: >> This restore the behavior prior to b018ddf633 which accidentally changed >> the return code to 0. Specifically guests probing for register existence >> were affected by this. >> >> Signed-off-by: Jan Kiszka > > For the record (I know you have a revert-patch on the list) > this patch breaks the 'musicpal' platform (my test image > no longer boots with this change). Yes, that's how I finally found out as well that this patch was wrong. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux