From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43348)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V7TLu-0004ny-18
	for qemu-devel@nongnu.org; Thu, 08 Aug 2013 12:46:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V7TLo-0000D1-To
	for qemu-devel@nongnu.org; Thu, 08 Aug 2013 12:46:17 -0400
Received: from cantor2.suse.de ([195.135.220.15]:50883 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V7TLo-0000Cq-Nx
	for qemu-devel@nongnu.org; Thu, 08 Aug 2013 12:46:12 -0400
Message-ID: <5203CB50.5090306@suse.de>
Date: Thu, 08 Aug 2013 18:46:08 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <51FCBF4E.90605@web.de> <51FCBFD2.3030401@web.de>
	<CAFEAcA8wfnXaZkHh_qpJbm5SzfNgthNdWS_g8N5VSHWp_0RW4A@mail.gmail.com>
In-Reply-To: <CAFEAcA8wfnXaZkHh_qpJbm5SzfNgthNdWS_g8N5VSHWp_0RW4A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/2] Revert "memory: Return -1 again on
 reads from unsigned regions"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Jan Kiszka <jan.kiszka@web.de>, qemu-devel <qemu-devel@nongnu.org>

Am 08.08.2013 17:23, schrieb Peter Maydell:
> On 3 August 2013 09:31, Jan Kiszka <jan.kiszka@web.de> wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> This reverts commit 9b8c69243585a32d14b9bb9fcd52c37b0b5a1b71.
>>
>> The commit was wrong: We only return -1 on invalid accesses, not on
>> valid but unbacked ones. This broke various corner cases.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>=20
> This revert fixes the regression in the 'musicpal' board.
>=20
> Presumably these two patches should go into 1.6 since it is
> a regression fix... cc'ing Anthony.

Since no one has spoken up with a concrete use case that breaks when
having the PIO region opaque, I agree this seems the best solution we
have for 1.6. But given the musicpal issue you have raised, I would ask
Paolo or Jan to squash these two patches together to avoid a git-bisect
regression.

Thanks,
Andreas

>=20
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>=20
> -- PMM
>=20


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg