From: David Daney <ddaney@caviumnetworks.com>
To: Christoph Lameter <cl@gentwo.org>
Cc: David Daney <ddaney.cavm@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Gilad Ben-Yossef <gilad@benyossef.com>,
<linux-kernel@vger.kernel.org>,
Chris Metcalf <cmetcalf@tilera.com>,
"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH] smp.c: Quit unconditionally enabling irqs in on_each_cpu_mask().
Date: Thu, 8 Aug 2013 13:27:52 -0700 [thread overview]
Message-ID: <5203FF48.7000903@caviumnetworks.com> (raw)
In-Reply-To: <000001405f6459b8-32fb5ffe-837b-41be-bec4-c9c05fd4f114-000000@email.amazonses.com>
On 08/08/2013 12:25 PM, Christoph Lameter wrote:
> On Thu, 8 Aug 2013, David Daney wrote:
>
>> I don't know of any bugs currently caused by this unconditional
>> local_irq_enable(), but I want to use this function in MIPS/OCTEON
>> early boot (when we have early_boot_irqs_disabled). This also makes
>> this function have similar semantics to on_each_cpu() which is good in
>> itself.
>
> smp_call_function_many() wants interrupts enabled.
That's what the comments say, but it isn't actually true.
The usage introduced by the patch is no different than the existing
usage in on_each_cpu() 30 line up in the file.
David Daney
next prev parent reply other threads:[~2013-08-08 20:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 18:25 [PATCH] smp.c: Quit unconditionally enabling irqs in on_each_cpu_mask() David Daney
2013-08-08 19:25 ` Christoph Lameter
2013-08-08 20:27 ` David Daney [this message]
2013-08-09 18:51 ` Gilad Ben-Yossef
2013-08-09 19:24 ` David Daney
2013-08-12 22:16 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5203FF48.7000903@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=cmetcalf@tilera.com \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=gilad@benyossef.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.