From: Stephen Warren <swarren@wwwdotorg.org>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: dri-devel@lists.freedesktop.org, Dave Airlie <airlied@redhat.com>,
linux-next@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v2] drm: provide agp dummies for CONFIG_AGP=n
Date: Thu, 08 Aug 2013 15:15:25 -0600 [thread overview]
Message-ID: <52040A6D.5020606@wwwdotorg.org> (raw)
In-Reply-To: <1375993152-2143-1-git-send-email-dh.herrmann@gmail.com>
On 08/08/2013 02:19 PM, David Herrmann wrote:
> We currently rely on gcc dead-code elimination so the drm_agp_* helpers
> are not called if drm_core_has_AGP() is false. That's ugly as hell so
> provide "static inline" dummies for the case that AGP is disabled.
>
> Fixes a build-regression introduced by:
>
> commit 28ec711cd427f8b61f73712a43b8100ba8ca933b
> Author: David Herrmann <dh.herrmann@gmail.com>
> Date: Sat Jul 27 16:37:00 2013 +0200
>
> drm/agp: move AGP cleanup paths to drm_agpsupport.c
Tested-by: Stephen Warren <swarren@nvidia.com>
prev parent reply other threads:[~2013-08-08 21:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 13:53 [PATCH] drm: provide agp dummies for CONFIG_AGP=n David Herrmann
2013-08-07 15:53 ` Laurent Pinchart
2013-08-07 16:12 ` David Herrmann
2013-08-07 16:52 ` Laurent Pinchart
2013-08-08 20:19 ` [PATCH v2] " David Herrmann
2013-08-08 21:15 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52040A6D.5020606@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=airlied@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dh.herrmann@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.